fix: changed dsr and demand shedding benchmarking#645
Open
AndreasHD11 wants to merge 2 commits intomasterfrom
Open
fix: changed dsr and demand shedding benchmarking#645AndreasHD11 wants to merge 2 commits intomasterfrom
AndreasHD11 wants to merge 2 commits intomasterfrom
Conversation
tgilon
reviewed
Apr 20, 2026
| other-non-res-oil-shale: chp and small thermal | ||
| other-non-res-oil-shale-old: chp and small thermal | ||
| other-non-res-oil-shale-new: chp and small thermal | ||
| load: demand shedding |
Member
There was a problem hiding this comment.
This does not remove the load from the benchmark (see the figure in the description, in which load is still present). It only removes the mapping.
daniel-rdt
reviewed
Apr 20, 2026
Member
daniel-rdt
left a comment
There was a problem hiding this comment.
Thank you @AndreasHD11 for spotting the issue and for this quick fix! This is looking good, except for the issue with Open-TYNDP load shedding still being listed in the capacity plots as pointed out by @tgilon. I guess you can exclude it here probably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #622
Changes proposed in this Pull Request
This PR proposes fixing the current benchmarking for dsr and demand shedding. In the VP and TYNDP report data, "demand shedding" is in reality dsr. In MM output, currently demand-side response explicit/implicit goes into demand shedding. However, this should be benchmarked against dsr instead. "Unserved energy" is the same as demand shedding for open-tyndp.
The mapping for MM, tyndp report and VP has been updated. Demand shedding in the power capacity plot has been removed. Unserved energy has been added to the power generation table for MM, and we can now compare our demand shedding with MM. One small fix to the plot has been made as some values for dsr in MM were negative (-0.0001) which led to the value going below the x axis.
Examples new outputs
Notes
Checklist
pixi.toml(usingpixi add <dependency-name>).config/config.default.yaml.doc/configtables/*.csv.config/test/*.yaml.pixi run -e open-tyndp tyndp-cyears-test).doc/*.rstfiles.doc/release_notes.rstis added.READMEanddoc/index.rst.