Skip to content

fix: changed dsr and demand shedding benchmarking#645

Open
AndreasHD11 wants to merge 2 commits intomasterfrom
fix/dsr-benchmarking
Open

fix: changed dsr and demand shedding benchmarking#645
AndreasHD11 wants to merge 2 commits intomasterfrom
fix/dsr-benchmarking

Conversation

@AndreasHD11
Copy link
Copy Markdown
Member

@AndreasHD11 AndreasHD11 commented Apr 17, 2026

Closes #622

Changes proposed in this Pull Request

This PR proposes fixing the current benchmarking for dsr and demand shedding. In the VP and TYNDP report data, "demand shedding" is in reality dsr. In MM output, currently demand-side response explicit/implicit goes into demand shedding. However, this should be benchmarked against dsr instead. "Unserved energy" is the same as demand shedding for open-tyndp.

The mapping for MM, tyndp report and VP has been updated. Demand shedding in the power capacity plot has been removed. Unserved energy has been added to the power generation table for MM, and we can now compare our demand shedding with MM. One small fix to the plot has been made as some values for dsr in MM were negative (-0.0001) which led to the value going below the x axis.

Examples new outputs

image image image

Notes

  1. Most dsr in power generation comes from DE. This is also the case for demand shedding.
  2. Our demand shedding is slightly higher than MM. This could be linked to the H2 CCGT finding, as DE also has the most amount of H2 CCGT. So if our H2 CCGT prices are higher than the fixed MM price, then more load shedding in open-tyndp could be taking place compared to MM.

Checklist

  • [ x] I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to pixi.toml (using pixi add <dependency-name>).
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Changes in configuration options are added in config/test/*.yaml.
  • The multiple weather/climate years test is passing locally (using pixi run -e open-tyndp tyndp-cyears-test).
  • Open-TYNDP SPDX license header added to all touched files.
  • For new data sources or versions, these instructions have been followed.
  • New rules are documented in the appropriate doc/*.rst files.
  • A release note doc/release_notes.rst is added.
  • Major features are documented with up-to-date information in README and doc/index.rst.
  • Module docstrings added to new Python scripts.

@AndreasHD11 AndreasHD11 added this to the Release v0.7 milestone Apr 17, 2026
@AndreasHD11 AndreasHD11 requested a review from daniel-rdt April 17, 2026 10:58
@AndreasHD11 AndreasHD11 self-assigned this Apr 17, 2026
@AndreasHD11 AndreasHD11 added the SB Scenario Building label Apr 17, 2026
other-non-res-oil-shale: chp and small thermal
other-non-res-oil-shale-old: chp and small thermal
other-non-res-oil-shale-new: chp and small thermal
load: demand shedding
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not remove the load from the benchmark (see the figure in the description, in which load is still present). It only removes the mapping.

Copy link
Copy Markdown
Member

@daniel-rdt daniel-rdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AndreasHD11 for spotting the issue and for this quick fix! This is looking good, except for the issue with Open-TYNDP load shedding still being listed in the capacity plots as pointed out by @tgilon. I guess you can exclude it here probably.

@AndreasHD11 AndreasHD11 requested a review from daniel-rdt April 20, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SB Scenario Building

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SUB] Add DSR to benchmarking

3 participants