Draft : Add agent astronomy shop and astronomy shop MCP server by fali007 · Pull Request #3148 · open-telemetry/opentelemetry-demo

fali007 · 2026-03-24T09:55:33Z

Changes

This is a Draft PR to demo changes to address #3140

Please provide a brief description of the changes here.

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

CHANGELOG.md updated to document new feature additions
Appropriate documentation updates in the docs
Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Signed-off-by: felixgeorge <felix.george@ibm.com>

github-actions · 2026-04-02T04:06:02Z

This PR was marked stale due to lack of activity. It will be closed in 7 days.

requested in otel-demo sig. [open-telemetry#3140] [open-telemetry#3148]

Signed-off-by: felixgeorge <felix.george@ibm.com>

ps48

@fali007 Added some initial set of comments. Also can you please rebase you PR on top of main to remove the conflicts!

ps48 · 2026-04-13T23:53:50Z

@@ -0,0 +1,140 @@
+#!/usr/bin/python


Looks like this is a dupe for src/agents/tools.py Can we just keep one?

Sure. Made the change

ps48 · 2026-04-13T23:57:04Z

+
+def convert_currency(from_currency: str, to_currency: str, amount: float):
+    """Convert between currencies."""
+    url = f"http://{BASE_URL}/api/currency/convert?from={from_currency}&to={to_currency}&amount={amount}"


Where is this route hosted? I see that the src/frontend/pages/api/currency.ts is the only handler to GET returning currencyCodes[]`. Currency conversion is done internally via gRPC (CurrencyGateway.convert) and is never exposed over HTTP.

Removed the tool

ps48 · 2026-04-13T23:58:27Z

+
+def get_shipping_quote(address_id: str):
+    """Get estimated shipping cost for a given address."""
+    url = f"http://{BASE_URL}/api/shipping/quote/{address_id}"


/api/shipping/quote/{address_id} does not exist. The actual endpoint is GET /api/shipping with query parameters itemList (JSON-stringified CartItem[]), currencyCode, and address (JSON-stringified Address). Should be something like:

url = f"http://{BASE_URL}/api/shipping" params = {"itemList": json.dumps(items), "currencyCode": currency, "address": json.dumps(address)}

Made the change

ps48 · 2026-04-13T23:59:44Z

+
+def get_cart():
+    """Retrieve the current contents of a user's cart."""
+    url = f"http://{BASE_URL}/api/cart"


Do we need session id here

opentelemetry-demo/src/frontend/pages/api/cart.ts

Line 17 in 5b70741

const { userId, items } = await CartGateway.getCart(sessionId as string);

def get_cart(sessionId: str): url = f"http://{BASE_URL}/api/cart" res = requests.get(url, params={"sessionId": sessionId})

Added session_id as request param

ps48 · 2026-04-14T00:01:40Z

+        if use_vcr:
+            cassette_name = f"{model_name.replace('/', '_')}_casette.yaml"
+        if "http_async_client" not in kwargs:
+            kwargs["http_async_client"] = httpx.AsyncClient(verify=False)


Should we gate this behind an env var (e.g., LLM_TLS_VERIFY). ? LLM provider is external is usually external so should we default to verify=True

Added behind env variable.

ps48 · 2026-04-14T00:09:17Z

+      jaeger:
+        condition: service_started
+      otel-collector:
+        condition: service_started
+      product-catalog:
+        condition: service_started


The chatbot only talks to the agent service, but its depends_on lists jaeger, otel-collector, and product-catalog. It should depend on agent instead.

Corrected the dependency for MCP and chatbot

ps48 · 2026-04-14T00:10:00Z

+AGENT_PORT=8010
+CHATBOT_PORT=7860
+LLM_BASE_URL=
+LLM_MODEL=Azure/gpt-4o


LLM_MODEL=Azure/gpt-4o the OpenTelemetry demo shouldn't default to a vendor-specific model. Please consider leaving this empty or using a placeholder with a comment explaining how to configure it.

ps48 · 2026-04-14T00:11:14Z

+        return f"Error fetching ads: {e}"
+
+
+def add_to_cart(userId: str, productId: str, quantity: int = 1):


The parameter names mix camelCase and snake_case: userId, productId (camelCase) vs product_id, from_currency, to_currency (snake_case). Since these become tool parameter names visible to the LLM, inconsistency can cause the agent to use wrong names. Please pick one convention (snake_case is Pythonic).

ps48 · 2026-04-14T00:12:25Z

+
+
+async def start_servers():
+    """Run both the LangGraph Agent and the MCP server concurrently."""


This looks like a stale docstring. We can say this runs the chat UI server?

Made the change

ps48 · 2026-04-14T00:12:46Z

+
+
+async def start_servers():
+    """Run both the LangGraph Agent and the MCP server concurrently."""


Same here, This looks like a stale docstring. We can say this runs the MCP server?

Made the change

Signed-off-by: felixgeorge <felix.george@ibm.com>

[3140] Add agent astronomy shop and astronomy shop MCP server

a2b98b5

Signed-off-by: felixgeorge <felix.george@ibm.com>

github-actions Bot added the helm-update-required Requires an update to the Helm chart when released label Mar 24, 2026

fali007 added 5 commits March 24, 2026 16:46

Add Dockerfile

f642af2

Signed-off-by: felixgeorge <felix.george@ibm.com>

Add package versions to requirements.txt

803f8d1

Signed-off-by: felixgeorge <felix.george@ibm.com>

Fix requirements.txt

9f7dbc6

Signed-off-by: felixgeorge <felix.george@ibm.com>

Add licence

2eaa316

Signed-off-by: felixgeorge <felix.george@ibm.com>

Fix vcr recording bug

0084067

Signed-off-by: felixgeorge <felix.george@ibm.com>

github-actions Bot added the Stale label Apr 2, 2026

julianocosta89 removed the Stale label Apr 2, 2026

fali007 and others added 4 commits April 9, 2026 00:36

Add separate components for agent, MCP and ChatBot related changes

9cd2754

requested in otel-demo sig. [open-telemetry#3140] [open-telemetry#3148]

Merge branch 'main' into main

2700d28

Fix yaml lint error

87b319a

Signed-off-by: felixgeorge <felix.george@ibm.com>

Merge branch 'main' into main

ab1b7bf

ps48 reviewed Apr 14, 2026

View reviewed changes

fali007 and others added 5 commits April 20, 2026 19:33

Merge branch 'main' into main

b65a252

Added changes requested in PR

4b0bf54

Signed-off-by: felixgeorge <felix.george@ibm.com>

Removed trailing space

34c79b4

Signed-off-by: felixgeorge <felix.george@ibm.com>

Removed additional spaces before line start

a20a658

Signed-off-by: felixgeorge <felix.george@ibm.com>

Merge branch 'main' into main

bd8ff14

		return f"Error fetching ads: {e}"


		def add_to_cart(userId: str, productId: str, quantity: int = 1):



		async def start_servers():
		"""Run both the LangGraph Agent and the MCP server concurrently."""

Conversation

fali007 commented Mar 24, 2026

Changes

Merge Requirements

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

ps48 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ps48 left a comment •

edited

Loading