Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,15 @@
},
{
customType: 'regex',
datasourceTemplate: 'java-version',
datasourceTemplate: 'docker',
managerFilePatterns: [
'.github/workflows/**',
],
matchStrings: [
'(?<currentValue>\\d+) # renovate\\(java-version\\)',
],
depNameTemplate: 'java',
extractVersionTemplate: '^(?<version>\\d+)',
// using zulu because new releases get published quickly
depNameTemplate: 'azul/zulu-openjdk',
},
{
customType: 'regex',
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- 11
- 17
- 21
- 25 # renovate(java-version)
- 26 # renovate(java-version)
# Collect coverage on latest LTS
include:
- os: ubuntu-latest
Expand All @@ -45,8 +45,8 @@ jobs:
name: Set up Java ${{ matrix.test-java-version }} for tests
uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
with:
# use corretto for testing, since it supports java 8 on more OS versions, including macos-latest
distribution: corretto
# using zulu for 26 because new releases get published quickly
distribution: zulu
Comment on lines -48 to +49
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if zulu works here also, since that's what we're using in other repos

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

java-version: ${{ matrix.test-java-version }}

- id: setup-java
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,9 @@ void positiveCases_externalDeprecatedApi() {
"ExternalDeprecated.java",
"package test;",
"public class ExternalDeprecated {",
" void method(Thread t) {",
" void method() {",
" // BUG: Diagnostic contains: Use of deprecated API",
" t.stop();",
" new Boolean(false);",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

" }",
"}")
.doTest();
Expand Down
Loading