Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
============================================
- Coverage 68.34% 68.28% -0.06%
Complexity 3009 3009
============================================
Files 449 449
Lines 8798 8798
============================================
- Hits 6013 6008 -5
- Misses 2785 2790 +5
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
opcache is always installed and not provided as a package in sury for 8.5+
|
NB that the upstream sury repo (which our developer image and shivammathur/setup-php use), doesn't have grpc yet, hence the two failures for 8.5 |
|
@brettmc rector config can also be adjusted :) |
oh yeah, of course. That's an important missing step, thanks! :) |
Nevay
left a comment
There was a problem hiding this comment.
Should also update CONTRIBUTING.md and Makefile.
|
@open-telemetry/php-approvers I think this is ready. 8.5 is still waiting on https://codeberg.org/oerdnj/deb.sury.org/issues/68 I believe... |
|
@brettmc do we keep support for 12 months after "green" EOL or "orange" EOL? |
Drop 8.1 support, and let rector upgrade the codebase with 8.2 as the minimum supported version