Require sem-conv >= 1.38 to prevent fatal errors from missing classes#1903
Open
ste93cry wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Require sem-conv >= 1.38 to prevent fatal errors from missing classes#1903ste93cry wants to merge 1 commit intoopen-telemetry:mainfrom
ste93cry wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1903 +/- ##
============================================
- Coverage 68.35% 68.27% -0.08%
Complexity 3009 3009
============================================
Files 449 449
Lines 8798 8798
============================================
- Hits 6014 6007 -7
- Misses 2784 2791 +7
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
29a215c to
6676c86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
composer.jsonconstraint foropentelemetry-php/sem-convto require version1.38. TheHostIncubatingAttributesandOsIncubatingAttributesclasses used by theHostresource detector were introduced in #1659 and first used in #1855. If a project upgrades the SDK whilesem-convremains outdated, it can lead to fatal errors when the detector tries to load classes that aren't available. This is exactly what happened in my case: Renovate updated the SDK because it was required in the project’s rootcomposer.json, butsem-convwas only a transitive dependency and was therefore ignored, leaving an incompatible version installed.While version
1.36technically contains the required classes, the SDK callsResourceInfo::createwith version1.38, so I updated the requirement to that version to stay consistent with what the SDK expects.