Skip to content

Support Protobuf 5.0#1904

Open
knobik wants to merge 1 commit intoopen-telemetry:mainfrom
knobik:main
Open

Support Protobuf 5.0#1904
knobik wants to merge 1 commit intoopen-telemetry:mainfrom
knobik:main

Conversation

@knobik
Copy link
Copy Markdown

@knobik knobik commented Mar 16, 2026

Added support for google protobuf v5.0, fixes issues with php 8.5

@knobik knobik requested a review from a team as a code owner March 16, 2026 10:13
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 16, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: knobik / name: knobik (d97c0c8)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.42%. Comparing base (e5a33a4) to head (d97c0c8).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1904      +/-   ##
============================================
- Coverage     68.35%   67.42%   -0.93%     
  Complexity     3009     3009              
============================================
  Files           449      449              
  Lines          8798     8796       -2     
============================================
- Hits           6014     5931      -83     
- Misses         2784     2865      +81     
Flag Coverage Δ
8.2 ?
8.3 ?
8.4 ?
8.5 67.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a33a4...d97c0c8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobstrecansky
Copy link
Copy Markdown
Contributor

@knobik - once you sign the CLA we should be able to get this in.

Copy link
Copy Markdown
Contributor

@bobstrecansky bobstrecansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on CLA and then we'll rock!

@knobik
Copy link
Copy Markdown
Author

knobik commented Mar 28, 2026

its a simple change, just remove my MR and do it yourselfs, im always getting 500 internal server error when trying to do CLA

@WyriHaximus
Copy link
Copy Markdown
Contributor

@knobik Looks like the CLA came through 5 minutes after you posted that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants