update http_request method, close #1105#1106
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
+ Coverage 27.41% 27.43% +0.01%
==========================================
Files 21 21
Lines 2834 2854 +20
Branches 427 431 +4
==========================================
+ Hits 777 783 +6
- Misses 2028 2042 +14
Partials 29 29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the http_request method to use an ADB‐backed HTTP connection instead of port forwarding with the requests library.
- Introduces a new AdbHTTPConnection subclass of HTTPConnection.
- Removes legacy port forwarding logic and updates request handling using JSON conversion.
| conn.request(method, path, headers=headers) | ||
| else: | ||
| conn.request(method, path, json.dumps(data), headers=headers) | ||
| except adbutils.AdbError as e: |
There was a problem hiding this comment.
It may be beneficial to log the exception details (e.g., using logger.error) before raising HTTPError for easier debugging of adb-related failures.
| except adbutils.AdbError as e: | |
| except adbutils.AdbError as e: | |
| logger.error("AdbError occurred while making HTTP request through adb: %s", str(e)) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
No description provided.