Update spec language to support pushing multiple tags at once#600
Open
jcarter3 wants to merge 1 commit intoopencontainers:mainfrom
Open
Update spec language to support pushing multiple tags at once#600jcarter3 wants to merge 1 commit intoopencontainers:mainfrom
jcarter3 wants to merge 1 commit intoopencontainers:mainfrom
Conversation
jcarter3
requested review from
dmcgowan,
jdolitsky,
jonjohnsonjr,
jzelinskie,
mikebrow,
stevvooe and
sudo-bmitch
as code owners
jcarter3
force-pushed
the
multiple-tag-push
branch
from
083f71d to
f271626
Compare
sudo-bmitch
requested changes
Feb 24, 2026
jcarter3
force-pushed
the
multiple-tag-push
branch
from
333daf2 to
fde1798
Compare
sudo-bmitch
reviewed
Mar 5, 2026
tianon
reviewed
Mar 12, 2026
sudo-bmitch
added a commit
to sudo-bmitch/regclient
that referenced
this pull request
Mar 19, 2026
Implementation of opencontainers/distribution-spec#600 Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
added a commit
to sudo-bmitch/olareg
that referenced
this pull request
Mar 19, 2026
Implementation of opencontainers/distribution-spec#600. Signed-off-by: Brandon Mitchell <git@bmitch.net>
This was referenced Mar 19, 2026
sudo-bmitch
requested changes
Mar 19, 2026
Contributor
sudo-bmitch
left a comment
sudo-bmitch
left a comment
There was a problem hiding this comment.
I noticed there's a newer version of the RFC. So this updates that pointer and makes some, hopefully minor, tweaks.
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 21, 2026
See opencontainers/distribution-spec#600 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 21, 2026
See opencontainers/distribution-spec#600 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 21, 2026
See opencontainers/distribution-spec#600 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 22, 2026
See opencontainers/distribution-spec#600 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
Contributor
|
I've added a test for this in the conformance redesign (disabled by default, but enabled with the |
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 22, 2026
See opencontainers/distribution-spec#600 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 22, 2026
See opencontainers/distribution-spec#600 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 26, 2026
See opencontainers/distribution-spec#600 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 28, 2026
See opencontainers/distribution-spec#600 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 29, 2026
See opencontainers/distribution-spec#600 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
andaaron
added a commit
to project-zot/zot
that referenced
this pull request
Mar 29, 2026
* feat: support pushing multiple tags for a single manifest See opencontainers/distribution-spec#600 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * fix: constants not replaced in swagger output Also godot mandates comments ending in dots, which produces bad results in the swagger generated files, see the extra ". which is now fixed below: ``` diff --git a/swagger/docs.go b/swagger/docs.go index 84b0827..fb2c45c 100644 --- a/swagger/docs.go +++ b/swagger/docs.go @@ -114,7 +114,7 @@ const docTemplate = `{ } }, "400": { - "description": "bad request\".", + "description": "bad request", "schema": { "type": "string" } @@ -200,7 +200,7 @@ const docTemplate = `{ } }, "400": { - "description": "bad request\".", + "description": "bad request", "schema": { "type": "string" } diff --git a/swagger/swagger.json b/swagger/swagger.json index cfeb390..247f95f 100644 --- a/swagger/swagger.json +++ b/swagger/swagger.json @@ -106,7 +106,7 @@ } }, "400": { - "description": "bad request\".", + "description": "bad request", "schema": { "type": "string" } @@ -192,7 +192,7 @@ } }, "400": { - "description": "bad request\".", + "description": "bad request", "schema": { "type": "string" } diff --git a/swagger/swagger.yaml b/swagger/swagger.yaml index 57641c2..09b30dc 100644 --- a/swagger/swagger.yaml +++ b/swagger/swagger.yaml @@ -310,7 +310,7 @@ paths: schema: type: string "400": - description: bad request". + description: bad request schema: type: string "500": @@ -366,7 +366,7 @@ paths: schema: type: string "400": - description: bad request". + description: bad request schema: type: string "500": ``` Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> --------- Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
Contributor
|
LGTM, just needs the DCO and merge conflicts resolved. We could also squash the commits on the rebase. https://github.com/opencontainers/distribution-spec/pull/600/checks?check_run_id=69878174291 |
jcarter3
force-pushed
the
multiple-tag-push
branch
from
e84b144 to
40573d3
Compare
…tiple tags at once. Also can be used when pushing tags for a non-canonical algorithm (sha-512, blake3) Co-authored-by: Brandon Mitchell <git@bmitch.net> Signed-off-by: Jeff Carter <jeff.carter@docker.com>
jcarter3
force-pushed
the
multiple-tag-push
branch
from
da0d61a to
7876da2
Compare
sudo-bmitch
approved these changes
Apr 5, 2026
Contributor
sudo-bmitch
left a comment
sudo-bmitch
left a comment
There was a problem hiding this comment.
I've used up my nit quota, so this LGTM.
dmcgowan
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also can be used when pushing tags for a non-canonical algorithm (sha-512, blake3)
Implements #591