Skip to content

chore(notebooks): update additional-tags to 3.4_ea1-v1.41 in PipelineRun YAMLs#118

Open
jiridanek wants to merge 1 commit intomainfrom
jd/2026/01/fixsvcacc
Open

chore(notebooks): update additional-tags to 3.4_ea1-v1.41 in PipelineRun YAMLs#118
jiridanek wants to merge 1 commit intomainfrom
jd/2026/01/fixsvcacc

Conversation

@jiridanek
Copy link
Copy Markdown
Member

@jiridanek jiridanek commented Jan 21, 2026

Needs to be reworked in view of

Description

Looking at diff in

I see that we need to update the version tag

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Updated container image tags across notebook and workbench pipeline configurations to reflect new runtime versions. All affected build pipelines now reference updated base image versions for consistent deployment across multiple runtime variants including CPU, CUDA, ROCm, and specialized configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

This pull request updates container image tags across 16 PipelineRun YAML configuration files in the notebooks directory. The additional-tags field is uniformly changed from 2025a-v1.35 to 3.4_ea1-v1.41 across all affected pipeline manifests.

Changes

Cohort / File(s) Summary
Runtime Pipelines
pipelineruns/notebooks/odh-pipeline-runtime-*.yaml
Updated additional-tags value from 2025a-v1.35 to 3.4_ea1-v1.41 across 7 runtime pipeline files (datascience-cpu, minimal-cpu, pytorch-cuda, pytorch-llmcompressor-cuda, pytorch-rocm, tensorflow-cuda, tensorflow-rocm variants)
Workbench Pipelines
pipelineruns/notebooks/odh-workbench-*.yaml
Updated additional-tags value from 2025a-v1.35 to 3.4_ea1-v1.41 across 9 workbench pipeline files (codeserver-datascience, jupyter-datascience, jupyter-minimal, jupyter-pytorch, jupyter-pytorch-llmcompressor, jupyter-tensorflow, jupyter-trustyai variants with cpu/cuda/rocm configurations)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A carrot-colored revision hops through the YAML fields,
Tags updated from old growth to new harvest yields,
From 2025a to 3.4, a version's gentle shift,
Sixteen pipelines now wear their spring-time gift! 🏷️

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating additional-tags to a specific version across PipelineRun YAMLs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (6)
pipelineruns/notebooks/odh-pipeline-runtime-datascience-cpu-py312-ubi9-push.yaml (1)

11-11: Push trigger should be restricted to the stable branch.

This PipelineRun still triggers on target_branch == "main", but push pipelines should only run on stable. Please switch the CEL expression accordingly. Based on learnings, this is required for notebooks push pipelines.

🔧 Suggested change
-    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && !("manifests/base/params-latest.env".pathChanged()) && ( "runtimes/datascience/ubi9-python-3.12/**".pathChanged() || "runtimes/datascience/ubi9-python-3.12/build-args/cpu.conf".pathChanged() || ".tekton/odh-pipeline-runtime-datascience-cpu-py312-ubi9-push.yaml".pathChanged() )
+    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "stable" && !("manifests/base/params-latest.env".pathChanged()) && ( "runtimes/datascience/ubi9-python-3.12/**".pathChanged() || "runtimes/datascience/ubi9-python-3.12/build-args/cpu.conf".pathChanged() || ".tekton/odh-pipeline-runtime-datascience-cpu-py312-ubi9-push.yaml".pathChanged() )
pipelineruns/notebooks/odh-workbench-jupyter-datascience-cpu-py312-ubi9-push.yaml (1)

11-11: Push trigger should be restricted to the stable branch.

This PipelineRun still triggers on target_branch == "main", but push pipelines should only run on stable. Please switch the CEL expression accordingly. Based on learnings, this is required for notebooks push pipelines.

🔧 Suggested change
-    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && !("manifests/base/params-latest.env".pathChanged()) && ( ".tekton/odh-workbench-jupyter-datascience-cpu-py312-ubi9-push.yaml".pathChanged() || "jupyter/utils/**".pathChanged() || "jupyter/datascience/ubi9-python-3.12/**".pathChanged() || "jupyter/datascience/ubi9-python-3.12/start-notebook.sh".pathChanged() || "jupyter/datascience/ubi9-python-3.12/build-args/cpu.conf".pathChanged() )
+    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "stable" && !("manifests/base/params-latest.env".pathChanged()) && ( ".tekton/odh-workbench-jupyter-datascience-cpu-py312-ubi9-push.yaml".pathChanged() || "jupyter/utils/**".pathChanged() || "jupyter/datascience/ubi9-python-3.12/**".pathChanged() || "jupyter/datascience/ubi9-python-3.12/start-notebook.sh".pathChanged() || "jupyter/datascience/ubi9-python-3.12/build-args/cpu.conf".pathChanged() )
pipelineruns/notebooks/odh-pipeline-runtime-minimal-cpu-py312-ubi9-push.yaml (1)

11-11: Push trigger should be restricted to the stable branch.

This PipelineRun still triggers on target_branch == "main", but push pipelines should only run on stable. Please switch the CEL expression accordingly. Based on learnings, this is required for notebooks push pipelines.

🔧 Suggested change
-    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && !("manifests/base/params-latest.env".pathChanged()) && ( "runtimes/minimal/ubi9-python-3.12/**".pathChanged() || "runtimes/minimal/ubi9-python-3.12/build-args/cpu.conf".pathChanged() || ".tekton/odh-pipeline-runtime-minimal-cpu-py312-ubi9-push.yaml".pathChanged() )
+    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "stable" && !("manifests/base/params-latest.env".pathChanged()) && ( "runtimes/minimal/ubi9-python-3.12/**".pathChanged() || "runtimes/minimal/ubi9-python-3.12/build-args/cpu.conf".pathChanged() || ".tekton/odh-pipeline-runtime-minimal-cpu-py312-ubi9-push.yaml".pathChanged() )
pipelineruns/notebooks/odh-workbench-jupyter-pytorch-rocm-py312-ubi9-push.yaml (1)

11-11: Push trigger should be restricted to the stable branch.

This PipelineRun still triggers on target_branch == "main", but push pipelines should only run on stable. Please switch the CEL expression accordingly. Based on learnings, this is required for notebooks push pipelines.

🔧 Suggested change
-    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && !("manifests/base/params-latest.env".pathChanged()) && ( ".tekton/odh-workbench-jupyter-pytorch-rocm-py312-ubi9-push.yaml".pathChanged() || "jupyter/rocm/pytorch/ubi9-python-3.12/**".pathChanged() || "jupyter/utils/**".pathChanged() || "jupyter/minimal/ubi9-python-3.12/start-notebook.sh".pathChanged() || "jupyter/datascience/ubi9-python-3.12/mongodb-org-6.0.repo-x86_64/**".pathChanged() || "jupyter/datascience/ubi9-python-3.12/mssql-2022.repo-x86_64/**".pathChanged() || "jupyter/datascience/ubi9-python-3.12/setup-elyra.sh".pathChanged() || "jupyter/rocm/pytorch/ubi9-python-3.12/build-args/rocm.conf".pathChanged() )
+    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "stable" && !("manifests/base/params-latest.env".pathChanged()) && ( ".tekton/odh-workbench-jupyter-pytorch-rocm-py312-ubi9-push.yaml".pathChanged() || "jupyter/rocm/pytorch/ubi9-python-3.12/**".pathChanged() || "jupyter/utils/**".pathChanged() || "jupyter/minimal/ubi9-python-3.12/start-notebook.sh".pathChanged() || "jupyter/datascience/ubi9-python-3.12/mongodb-org-6.0.repo-x86_64/**".pathChanged() || "jupyter/datascience/ubi9-python-3.12/mssql-2022.repo-x86_64/**".pathChanged() || "jupyter/datascience/ubi9-python-3.12/setup-elyra.sh".pathChanged() || "jupyter/rocm/pytorch/ubi9-python-3.12/build-args/rocm.conf".pathChanged() )
pipelineruns/notebooks/odh-pipeline-runtime-pytorch-rocm-py312-ubi9-push.yaml (1)

11-11: Push trigger should be restricted to the stable branch.

This PipelineRun still triggers on target_branch == "main", but push pipelines should only run on stable. Please switch the CEL expression accordingly. Based on learnings, this is required for notebooks push pipelines.

🔧 Suggested change
-    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && !("manifests/base/params-latest.env".pathChanged()) && (".tekton/odh-pipeline-runtime-pytorch-rocm-py312-ubi9-push.yaml".pathChanged() || "runtimes/rocm-pytorch/ubi9-python-3.12/**".pathChanged() || "runtimes/rocm-pytorch/ubi9-python-3.12/build-args/rocm.conf".pathChanged() )
+    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "stable" && !("manifests/base/params-latest.env".pathChanged()) && (".tekton/odh-pipeline-runtime-pytorch-rocm-py312-ubi9-push.yaml".pathChanged() || "runtimes/rocm-pytorch/ubi9-python-3.12/**".pathChanged() || "runtimes/rocm-pytorch/ubi9-python-3.12/build-args/rocm.conf".pathChanged() )
pipelineruns/notebooks/odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-ubi9-push.yaml (1)

11-11: Push trigger should be restricted to the stable branch.

This PipelineRun still triggers on target_branch == "main", but push pipelines should only run on stable. Please switch the CEL expression accordingly. Based on learnings, this is required for notebooks push pipelines.

🔧 Suggested change
-    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && !("manifests/base/params-latest.env".pathChanged()) && ( ".tekton/odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-ubi9-push.yaml".pathChanged() || "runtimes/pytorch+llmcompressor/ubi9-python-3.12/**".pathChanged() || "runtimes/pytorch+llmcompressor/ubi9-python-3.12/build-args/cuda.conf".pathChanged() )
+    pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "stable" && !("manifests/base/params-latest.env".pathChanged()) && ( ".tekton/odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-ubi9-push.yaml".pathChanged() || "runtimes/pytorch+llmcompressor/ubi9-python-3.12/**".pathChanged() || "runtimes/pytorch+llmcompressor/ubi9-python-3.12/build-args/cuda.conf".pathChanged() )

Gregory-Pereira pushed a commit to Gregory-Pereira/odh-konflux-central that referenced this pull request Apr 3, 2026
…insk_rhoai-2.21_notebook_trustyai_cpu

add jupyter-trustyai-cpu-py311-ubi9-n-v2-21 pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant