Update kserve release reference from v0.17 to v0.15#64
Conversation
📝 WalkthroughWalkthroughUpdates the Git reference for the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Security ConsiderationActionable concern: Reverting to 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/kserve-release.yaml:
- Line 87: The workflow currently pins the external checkout action to a mutable
branch ref: 'release-v0.15'; update that ref to the exact immutable commit SHA
for the opendatahub-io/kserve checkout used by the release job (the job that has
packages: write permission) so the action uses a specific commit instead of a
branch; replace the value for ref: 'release-v0.15' with the repository commit
SHA corresponding to the intended release commit (obtain the SHA from the
upstream repo) to ensure immutability.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 8e742b52-0858-4aad-9750-6b13516c4e26
📒 Files selected for processing (1)
.github/workflows/kserve-release.yaml
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -84,7 +84,7 @@ jobs: | |||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |||
| with: | |||
| repository: 'opendatahub-io/kserve' | |||
There was a problem hiding this comment.
if we use RHDS kserve rhoai-3.4-eaX branch, it should be better?
Description
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit