Skip to content

Update kserve release reference from v0.17 to v0.15#64

Open
pierDipi wants to merge 1 commit intomainfrom
pierDipi-patch-1
Open

Update kserve release reference from v0.17 to v0.15#64
pierDipi wants to merge 1 commit intomainfrom
pierDipi-patch-1

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Apr 7, 2026

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Updated the KServe Git reference used in the release workflow.

@openshift-ci openshift-ci bot added the approved label Apr 7, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

📝 Walkthrough

Walkthrough

Updates the Git reference for the opendatahub-io/kserve repository in the release-dev job from release-v0.17 to release-v0.15. The change affects only the ref parameter in the checkout step; all downstream workflow steps remain unmodified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Security Consideration

Actionable concern: Reverting to release-v0.15 from release-v0.17 requires explicit justification. Older releases may contain known vulnerabilities that were patched in newer versions. Verify that this downgrade is intentional and not accidental. If intentional, document the reason in the commit message or PR description. Cross-reference any relevant security advisories affecting v0.15 that may have been resolved in v0.17.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the single substantive change: updating a kserve release reference from v0.17 to v0.15.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/kserve-release.yaml:
- Line 87: The workflow currently pins the external checkout action to a mutable
branch ref: 'release-v0.15'; update that ref to the exact immutable commit SHA
for the opendatahub-io/kserve checkout used by the release job (the job that has
packages: write permission) so the action uses a specific commit instead of a
branch; replace the value for ref: 'release-v0.15' with the repository commit
SHA corresponding to the intended release commit (obtain the SHA from the
upstream repo) to ensure immutability.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8e742b52-0858-4aad-9750-6b13516c4e26

📥 Commits

Reviewing files that changed from the base of the PR and between 1a314a2 and 36382bc.

📒 Files selected for processing (1)
  • .github/workflows/kserve-release.yaml

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -84,7 +84,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: 'opendatahub-io/kserve'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we use RHDS kserve rhoai-3.4-eaX branch, it should be better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants