fix: deep copy labels and annotations in SyncPodToGs#329
Conversation
…me label sync works The oldGsLabels and oldGsAnnotations were direct references to the internal map, causing reflect.DeepEqual to always return true after modifications. This prevented the patch operation from executing, making the nodeName label (and other metadata changes) never persist to the GameServer object.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 40.76% 40.77%
=======================================
Files 112 112
Lines 12544 12548 +4
=======================================
+ Hits 5114 5116 +2
- Misses 7019 7020 +1
- Partials 411 412 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.