Skip to content

SPLAT-2562: Added 3CMO OTE binary to extensionBinary list#31004

Open
vr4manta wants to merge 1 commit intoopenshift:mainfrom
vr4manta:SPLAT-2562
Open

SPLAT-2562: Added 3CMO OTE binary to extensionBinary list#31004
vr4manta wants to merge 1 commit intoopenshift:mainfrom
vr4manta:SPLAT-2562

Conversation

@vr4manta
Copy link
Copy Markdown
Contributor

@vr4manta vr4manta commented Apr 13, 2026

SPLAT-2562

Changes

  • Added 3CMO OTE binary to extensionBinary list

Summary by CodeRabbit

  • Tests
    • Added test binary support for cluster-cloud-controller-manager-operator to enhance test coverage and validation capabilities.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 13, 2026

@vr4manta: This pull request references SPLAT-2562 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

SPLAT-2562

Changes

  • Added 3CMO OTE binary to extensionBinary list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 13, 2026

@vr4manta: This pull request references SPLAT-2562 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

SPLAT-2562

Changes

  • Added 3CMO OTE binary to extensionBinary list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a5bf573a-3d38-42ee-87bf-6bfe0d7a88ef

📥 Commits

Reviewing files that changed from the base of the PR and between 1a93dad and 49ac512.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go

Walkthrough

A new test binary entry was added to the extensionBinaries registry in pkg/test/extensions/binary.go, mapping the cluster-cloud-controller-manager-operator image tag to its corresponding external binary path.

Changes

Cohort / File(s) Summary
Test Extension Binary Registry
pkg/test/extensions/binary.go
Added a new TestBinary entry to the extensionBinaries slice registering the cluster-cloud-controller-manager-operator image with its external test binary path (/usr/bin/cluster-cloud-controller-manager-operator-tests-ext.gz).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❓ Inconclusive The PR adds a registry entry for cluster-cloud-controller-manager-operator-tests-ext binary, but the actual source code is not included in this PR. Verify that the cluster-cloud-controller-manager-operator binary does not write to stdout in main(), init(), or suite setup functions, as this would violate the OTE binary stdout contract.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change—adding a new 3CMO OTE binary entry to the extensionBinary list—and is specific and concise.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The PR adds a static data entry to the extensionBinaries registry, not a Ginkgo test definition. No test naming constructs are introduced or modified.
Test Structure And Quality ✅ Passed The PR only adds a registry entry to extensionBinaries, not Ginkgo test code. The custom check applies to test specifications, not configuration data structures.
Microshift Test Compatibility ✅ Passed Pull request adds only metadata entry to extensionBinaries registry, not new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests, only registers an external test binary configuration entry, so SNO compatibility assessment is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR adds a test binary registry entry to pkg/test/extensions/binary.go with no scheduling constraints.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only adds a registry entry for a test binary path in the extensionBinaries slice—it is a configuration change, not a test definition. No Ginkgo test code is added in this PR, making the check not applicable.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 13, 2026

@vr4manta: This pull request references SPLAT-2562 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

SPLAT-2562

Changes

  • Added 3CMO OTE binary to extensionBinary list

Summary by CodeRabbit

  • Tests
  • Added test binary support for cluster-cloud-controller-manager-operator to enhance test coverage and validation capabilities.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vr4manta
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 13, 2026

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#446
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f266b2b0-3764-11f1-8c07-104d53b44395-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 13, 2026

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#446
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-upi-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb832810-3764-11f1-8907-5666d5c705c5-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#446
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c1446500-37fb-11f1-9e15-01b3d3bcf6b0-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#446
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-upi-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d02b1780-37fb-11f1-8e58-f4f4ae1466a8-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#446
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bcd8dc60-38de-11f1-8429-118b8b845f66-0

@vr4manta vr4manta marked this pull request as ready for review April 17, 2026 16:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2026
@vr4manta
Copy link
Copy Markdown
Contributor Author

/hold
holding till other PR merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2026
@openshift-ci openshift-ci bot requested review from deads2k and sjenning April 17, 2026 16:15
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 17, 2026

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 49ac512 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-fips 49ac512 link true /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn-upgrade 49ac512 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-microshift-serial 49ac512 link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-serial-2of2 49ac512 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-vsphere-ovn 49ac512 link true /test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-microshift 49ac512 link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-csi 49ac512 link true /test e2e-aws-csi
ci/prow/e2e-gcp-ovn 49ac512 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-serial-1of2 49ac512 link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-gcp-csi 49ac512 link true /test e2e-gcp-csi
ci/prow/e2e-vsphere-ovn-upi 49ac512 link true /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants