range_tree: Provide more debug details upon unexpected add/remove#17581
Merged
amotin merged 1 commit intoopenzfs:masterfrom Jul 31, 2025
Merged
range_tree: Provide more debug details upon unexpected add/remove#17581amotin merged 1 commit intoopenzfs:masterfrom
amotin merged 1 commit intoopenzfs:masterfrom
Conversation
13 tasks
amotin
approved these changes
Jul 30, 2025
Member
amotin
left a comment
amotin
left a comment
There was a problem hiding this comment.
Thank you! Please just fix one long line to make checkstyle happy. Plus couple optional comments, if you like:
behlendorf
approved these changes
Jul 30, 2025
ihoro
force-pushed
the
range_tree_overlapping_debug
branch
from
d7c9c1a to
8676625
Compare
Sponsored-by: Klara, Inc. Signed-off-by: Igor Ostapenko <igor.ostapenko@klarasystems.com>
ihoro
force-pushed
the
range_tree_overlapping_debug
branch
from
8676625 to
93092fe
Compare
Contributor
Author
|
Thanks for review, I think I've covered all the comments. |
behlendorf
approved these changes
Jul 31, 2025
behlendorf
added
Status: Accepted
amotin
approved these changes
Jul 31, 2025
amotin
pushed a commit
that referenced
this pull request
Aug 5, 2025
Sponsored-by: Klara, Inc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> Signed-off-by: Igor Ostapenko <igor.ostapenko@klarasystems.com> Closes #17581
amotin
pushed a commit
to truenas/zfs
that referenced
this pull request
Aug 17, 2025
Sponsored-by: Klara, Inc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> Signed-off-by: Igor Ostapenko <igor.ostapenko@klarasystems.com> Closes openzfs#17581
amotin
pushed a commit
to truenas/zfs
that referenced
this pull request
Aug 17, 2025
Sponsored-by: Klara, Inc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> Signed-off-by: Igor Ostapenko <igor.ostapenko@klarasystems.com> Closes openzfs#17581
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Aug 28, 2025
Sponsored-by: Klara, Inc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> Signed-off-by: Igor Ostapenko <igor.ostapenko@klarasystems.com> Closes openzfs#17581
spauka
pushed a commit
to spauka/zfs
that referenced
this pull request
Aug 30, 2025
Sponsored-by: Klara, Inc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> Signed-off-by: Igor Ostapenko <igor.ostapenko@klarasystems.com> Closes openzfs#17581
bugclerk
pushed a commit
to truenas/zfs
that referenced
this pull request
Sep 8, 2025
Sponsored-by: Klara, Inc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> Signed-off-by: Igor Ostapenko <igor.ostapenko@klarasystems.com> Closes openzfs#17581 (cherry picked from commit c1e8ab8)
lundman
pushed a commit
to openzfsonosx/openzfs-fork
that referenced
this pull request
Jan 30, 2026
Sponsored-by: Klara, Inc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> Signed-off-by: Igor Ostapenko <igor.ostapenko@klarasystems.com> Closes openzfs#17581
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Feb 23, 2026
Sponsored-by: Klara, Inc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> Signed-off-by: Igor Ostapenko <igor.ostapenko@klarasystems.com> Closes openzfs#17581
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sponsored-by: Klara, Inc.
Motivation and Context
Whenever unexpected addition or removal happens to a range tree the panic string provides more details for debugging: metaslab id, vdev guid, spa name, range tree name, etc.
Description
A new entrypoint for range tree creation was added --
zfs_range_tree_create_flags()function with extraflagsandnameparameters. The only flag for now isZFS_RT_F_DYN_NAMEwhat means that the given name reference is a dynamic buffer which must be freed when the range tree is being destroyed.How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.