Skip to content

Fix type in dbrrd_closest()#17733

Merged
behlendorf merged 1 commit intoopenzfs:masterfrom
amotin:dbrrd_closest_type
Sep 12, 2025
Merged

Fix type in dbrrd_closest()#17733
behlendorf merged 1 commit intoopenzfs:masterfrom
amotin:dbrrd_closest_type

Conversation

@amotin
Copy link
Copy Markdown
Member

@amotin amotin commented Sep 12, 2025 •
edited
Loading

For ABS() to work, the argument must be signed, but rrdd_time is uint64_t. Clang noticed it.

Fixes: #16853

How Has This Been Tested?

Build successfully with Clang on FreeBSD.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Fix type in dbrrd_closest()
8e9ee28 
For ABS() to work, the argument must be signed, but rrdd_time is
uint64_t.  Clang noticed it.

Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
@amotin
Copy link
Copy Markdown
Member Author

amotin commented Sep 12, 2025

@oshogbo ^^^

@amotin amotin added the Status: Code Review Needed Ready for review and testing label Sep 12, 2025
@oshogbo
Copy link
Copy Markdown
Contributor

oshogbo commented Sep 12, 2025

Thanks!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 12, 2025
@behlendorf behlendorf merged commit bc8bcfc into openzfs:master Sep 12, 2025
23 of 26 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 12, 2025
@amotin @behlendorf
Fix type in dbrrd_closest()
41c6eaa 
For ABS() to work, the argument must be signed, but rrdd_time is
uint64_t.  Clang noticed it.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Fixes openzfs#16853
Closes openzfs#17733
@amotin amotin deleted the dbrrd_closest_type branch September 13, 2025 17:13
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Jan 30, 2026
@amotin @lundman
Fix type in dbrrd_closest()
183bddf 
For ABS() to work, the argument must be signed, but rrdd_time is
uint64_t.  Clang noticed it.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Fixes openzfs#16853
Closes openzfs#17733
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@amotin @lundman
Fix type in dbrrd_closest()
9f4ae52 
For ABS() to work, the argument must be signed, but rrdd_time is
uint64_t.  Clang noticed it.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Signed-off-by: Alexander Motin <alexander.motin@TrueNAS.com>
Fixes openzfs#16853
Closes openzfs#17733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behlendorf behlendorf behlendorf approved these changes

+1 more reviewer

@oshogbo oshogbo oshogbo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amotin @oshogbo @behlendorf