zfs receive: add test to reproduce issue #18344#18355
zfs receive: add test to reproduce issue #18344#18355GarthSnyder wants to merge 1 commit intoopenzfs:masterfrom
Conversation
This is a test that demonstrates issue openzfs#18344. I've added redacted streams of both endiannesses and a harness that attempts to zfs recv the opposite-endian version. This should be marked as a known issue if I've set it up correctly. Signed-off-by: Garth Snyder <garth@garthsnyder.com>
There was a problem hiding this comment.
Pull request overview
Adds a ZFS Test Suite case intended to reproduce OpenZFS issue #18344 (failure to zfs receive a redacted send stream produced on the opposite endianness), by shipping pre-recorded redacted send streams for both byte orders and a harness that selects the opposite-endian stream at runtime.
Changes:
- Add
redacted_opposite_endianfunctional test that attempts to receive a prebuilt opposite-endian redacted stream intoPOOL2. - Add big-endian and little-endian redacted send streams (
.zsend.bz2) to the test data distribution. - Register the new test in the runfile and mark it as a known failure linked to issue #18344 in
zts-report.py.in.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/zfs-tests/tests/Makefile.am | Distributes the new opposite-endian stream artifacts and installs the new test script. |
| tests/zfs-tests/tests/functional/redacted_send/redacted_opposite_endian.ksh | New test selecting an opposite-endian stream and running `bzcat |
| tests/zfs-tests/tests/functional/redacted_send/little-endian-redacted.zsend.bz2 | Adds a prebuilt little-endian redacted send stream fixture. |
| tests/zfs-tests/tests/functional/redacted_send/big-endian-redacted.zsend.bz2 | Adds a prebuilt big-endian redacted send stream fixture. |
| tests/test-runner/bin/zts-report.py.in | Marks the new test as a known failure tied to GitHub issue 18344. |
| tests/runfiles/common.run | Includes redacted_opposite_endian in the redacted_send functional test group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/zfs-tests/tests/functional/redacted_send/redacted_opposite_endian.ksh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/zfs-tests/tests/functional/redacted_send/redacted_opposite_endian.ksh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Should this be a part of #18372 instead of marked as ignored? Or it triggers more than that one issue? |
b07b6e2 to
c508d12
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is a test that demonstrates issue #18344. I've added redacted streams of both endiannesses and a harness that attempts to zfs recv the opposite-endian version. This should be marked as a known issue if I've set it up correctly.
Types of changes
Checklist:
Signed-off-by.