Skip to content

zfs receive: add test to reproduce issue #18344#18355

Open
GarthSnyder wants to merge 1 commit intoopenzfs:masterfrom
GarthSnyder:pr-18344
Open

zfs receive: add test to reproduce issue #18344#18355
GarthSnyder wants to merge 1 commit intoopenzfs:masterfrom
GarthSnyder:pr-18344

Conversation

@GarthSnyder
Copy link
Copy Markdown
Contributor

This is a test that demonstrates issue #18344. I've added redacted streams of both endiannesses and a harness that attempts to zfs recv the opposite-endian version. This should be marked as a known issue if I've set it up correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

This is a test that demonstrates issue openzfs#18344. I've added redacted
streams of both endiannesses and a harness that attempts to zfs
recv the opposite-endian version. This should be marked as a
known issue if I've set it up correctly.

Signed-off-by: Garth Snyder <garth@garthsnyder.com>
@github-actions github-actions bot added the Status: Work in Progress Not yet ready for general review label Mar 20, 2026
@GarthSnyder GarthSnyder marked this pull request as ready for review March 20, 2026 06:24
Copilot AI review requested due to automatic review settings March 20, 2026 06:24
@github-actions github-actions bot added Status: Code Review Needed Ready for review and testing and removed Status: Work in Progress Not yet ready for general review labels Mar 20, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a ZFS Test Suite case intended to reproduce OpenZFS issue #18344 (failure to zfs receive a redacted send stream produced on the opposite endianness), by shipping pre-recorded redacted send streams for both byte orders and a harness that selects the opposite-endian stream at runtime.

Changes:

  • Add redacted_opposite_endian functional test that attempts to receive a prebuilt opposite-endian redacted stream into POOL2.
  • Add big-endian and little-endian redacted send streams (.zsend.bz2) to the test data distribution.
  • Register the new test in the runfile and mark it as a known failure linked to issue #18344 in zts-report.py.in.

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/zfs-tests/tests/Makefile.am Distributes the new opposite-endian stream artifacts and installs the new test script.
tests/zfs-tests/tests/functional/redacted_send/redacted_opposite_endian.ksh New test selecting an opposite-endian stream and running `bzcat
tests/zfs-tests/tests/functional/redacted_send/little-endian-redacted.zsend.bz2 Adds a prebuilt little-endian redacted send stream fixture.
tests/zfs-tests/tests/functional/redacted_send/big-endian-redacted.zsend.bz2 Adds a prebuilt big-endian redacted send stream fixture.
tests/test-runner/bin/zts-report.py.in Marks the new test as a known failure tied to GitHub issue 18344.
tests/runfiles/common.run Includes redacted_opposite_endian in the redacted_send functional test group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amotin
Copy link
Copy Markdown
Member

amotin commented Apr 7, 2026

Should this be a part of #18372 instead of marked as ignored? Or it triggers more than that one issue?

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Code Review Needed Ready for review and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants