Fix: draid autopkgtests fail on s390x architecture (Endianness Issue)#18445
Merged
behlendorf merged 1 commit intoopenzfs:masterfrom Apr 22, 2026
Merged
Fix: draid autopkgtests fail on s390x architecture (Endianness Issue)#18445behlendorf merged 1 commit intoopenzfs:masterfrom
behlendorf merged 1 commit intoopenzfs:masterfrom
Conversation
andriytk
approved these changes
Apr 21, 2026
Contributor
|
One last change. To resolve the checkstyle failure you'll need to download the updated ABI files from the PR artifacts here, https://github.com/openzfs/zfs/actions/runs/24707802425?pr=18445. Then add the updated |
The ioctl call to create the pool was returning -1 with errno EINVAL. Inside the module code, inside vdev_draid.c, verify_perms is calling fletcher_4_native_varsize. This in turn calls fletcher_4_scalar_native. So, implemented a fletcher_4_byteswap_varsize which makes use of the fletcher_4_scalar_byteswap in Big endian machines. Signed-off-by: Pranav P <pranavsdreams@gmail.com> Closes openzfs#16261
7e244a1 to
2e799e2
Compare
yurikoles
approved these changes
Apr 22, 2026
behlendorf
approved these changes
Apr 22, 2026
Contributor
behlendorf
left a comment
There was a problem hiding this comment.
It looks like we have a few additional recent ABI changes which didn't get flagged initially. Those should have been part of their original commits, but we can fix it up here. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Creating a draid1 pool was resulting in the following error:
This patch fixes this issue. Closes #16261
Description
The ioctl call to create the pool was returning -1 with errno EINVAL. Inside the module code, inside vdev_draid.c, verify_perms is calling fletcher_4_native_varsize. This in turn calls fletcher_4_scalar_native. So, implemented a fletcher_4_byteswap_varsize which makes use of the fletcher_4_scalar_byteswap in Big endian machines.
How Has This Been Tested?
draid verifyto verify the generated draid mapsTypes of changes
Checklist:
Signed-off-by.