ZTS: zpool_export_parallel_admin.sh busy export#18447
Merged
behlendorf merged 1 commit intoopenzfs:masterfrom Apr 22, 2026
Merged
ZTS: zpool_export_parallel_admin.sh busy export#18447behlendorf merged 1 commit intoopenzfs:masterfrom
behlendorf merged 1 commit intoopenzfs:masterfrom
Conversation
If the pool is active 'zpool export' will fail resulting in a test failure. Swap log_must with log_must_busy so the export is retried when reported as busy before failing the test. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
There was a problem hiding this comment.
Pull request overview
This PR hardens the ZFS Test Suite (ZTS) zpool_export_parallel_admin test against transient zpool export failures when the pool is reported as busy, addressing a CI flake observed in cli_root/zpool_export/zpool_export_parallel_admin.
Changes:
- Replace
log_mustwithlog_must_busyforzpool exportso the test retries on “busy” before failing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tonyhutter
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
https://github.com/openzfs/zfs/actions/runs/24734611095/job/72358686292?pr=18436
Description
If the pool is active 'zpool export' will fail resulting in a test failure. Swap log_must with log_must_busy so the export is retried when reported as busy before failing the test.
How Has This Been Tested?
Will be tested by the CI.
Types of changes