Make config in-line with next version of Perses Operator (merge after next Perses Operator release)#94
Draft
saswatamcode wants to merge 1 commit intoperses:mainfrom
Draft
Make config in-line with next version of Perses Operator (merge after next Perses Operator release)#94saswatamcode wants to merge 1 commit intoperses:mainfrom
saswatamcode wants to merge 1 commit intoperses:mainfrom
Conversation
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Member
Author
|
Looks like this api change wasn't in latest Perses Operator release, we'll wait till next major bump |
Member
|
I had logged #239 while working on integrating with kube-prometheus, it looks like this is related. https://github.com/perses/perses-operator/releases latest v0.3.2 is available now and we are good to proceed to migrate to v1alpha2 as well @saswatamcode would you be continuing with this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perses Operator will have breaking changes in config in next version.
This commit brings the YAML + jsonnet up to speed with that.
cc: @jgbernalp for when next version of Perses Operator is release.