Limit datachannel IDs based on SCTP stream Ids#3405
Open
pando-emil wants to merge 1 commit intopion:mainfrom
Open
Limit datachannel IDs based on SCTP stream Ids#3405pando-emil wants to merge 1 commit intopion:mainfrom
pando-emil wants to merge 1 commit intopion:mainfrom
Conversation
NOTE! This patch depends on a corresponding patch in sctp that adds the numInboundStreams, numOutboundStreams and OnStreamResetComplete functions on Association. When an SCTP association is setup, the number of streams in each direction is "negotiated" between the peers. The max number of streams also determines the maximum ID a stream can be identified as. This patch makes sure to not trying to use stream IDs outside the valid range. The patch also makes sure IDs can be reused after reset. Before this patch, you could never open datachannels more than 65535 / 2 times within a session, even you only have one in use at a time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE! This patch depends on a corresponding patch in sctp (pion/sctp#463) that adds the numInboundStreams, numOutboundStreams and OnStreamResetComplete functions on Association.
When an SCTP association is setup, the number of streams in each direction is "negotiated" between the peers. The max number of streams also determines the maximum ID a stream can be identified as.
This patch makes sure to not trying to use stream IDs outside the valid range.
The patch also makes sure IDs can be reused after reset. Before this patch, you could never open datachannels more than 65535 / 2 times within a session, even you only have one in use at a time.