Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the engine to the latest version, adds support for SOGS scenes, and implements double-click focus functionality for meshes and GSplats using a new picker implementation. Key changes include replacing the old depth-reading approach with a new Picker class, updating camera controls (including resetting via the R key and adjusting fly speed), and removing the deprecated read-depth module.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/viewer.ts | Updates to camera control, double-click focus via picker, and enhancements to loadPly to support external URLs |
| src/read-depth.ts | Removal of the deprecated depth reading implementation |
| src/picker.ts | Addition of a new Picker class for handling picking logic |
| src/multiframe.ts | Type adjustments to use GraphicsDevice instead of WebglGraphicsDevice |
| src/index.tsx | Minor cleanup (removed extraneous whitespace) |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/viewer.ts:1163
- [nitpick] Consider using a properly typed object or a Map instead of 'any' for holding external URL mappings to improve type safety and code clarity.
const urls: any = {};
mvaligursky
reviewed
Apr 17, 2025
mvaligursky
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: