Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies and addresses issues with WebGPU picking.
- Adjusts the y-coordinate computation for WebGL2 in the picking logic.
- Introduces an 'immediate' flag to the colorBuffer.read call to promptly trigger read operations.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
src/picker.ts:39
- Verify that the inversion of the y coordinate using 'height - y - 1' for WebGL2 aligns with the intended picking behavior; ensure that this calculation deals with coordinate system differences correctly.
const pixels = await picker.renderTarget.colorBuffer.read(x, graphicsDevice.isWebGL2 ? height - y - 1 : y, 1, 1, {
src/picker.ts:41
- Ensure that the addition of 'immediate: true' is compatible with the existing renderTarget.read usage and does not introduce unexpected behavior in other rendering modes.
immediate: true
mvaligursky
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dependencies and fix WebGPU picking.