Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates project dependencies and implements lazy loading for the PNG exporter while making some build configuration improvements.
- Updates various npm dependencies to their latest versions
- Implements on-demand construction of the PNG exporter to improve initialization performance
- Simplifies build configuration by removing unused variables and streamlining TypeScript compiler options
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/viewer.ts | Removes eager PNG exporter initialization and implements lazy loading in downloadPngScreenshot method; adds 'sog' file extension support |
| src/png-exporter.ts | Improves async handling by moving lodepng initialization outside the message handler |
| rollup.config.mjs | Simplifies build configuration by consolidating engine path logic and removing unused PCUI variables |
| package.json | Updates multiple dependencies to latest versions including TypeScript, ESLint, and PlayCanvas |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
willeastcott
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And also: