Skip to content

Update engine#340

Merged
slimbuck merged 3 commits intomainfrom
update-deps
Sep 3, 2025
Merged

Update engine#340
slimbuck merged 3 commits intomainfrom
update-deps

Conversation

@slimbuck
Copy link
Copy Markdown
Member

@slimbuck slimbuck commented Sep 3, 2025

And also:

  • small build updates
  • construct png encoder on demand

@slimbuck slimbuck requested review from a team and Copilot September 3, 2025 12:08
@slimbuck slimbuck self-assigned this Sep 3, 2025
@slimbuck slimbuck added the enhancement New feature or request label Sep 3, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates project dependencies and implements lazy loading for the PNG exporter while making some build configuration improvements.

  • Updates various npm dependencies to their latest versions
  • Implements on-demand construction of the PNG exporter to improve initialization performance
  • Simplifies build configuration by removing unused variables and streamlining TypeScript compiler options

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/viewer.ts Removes eager PNG exporter initialization and implements lazy loading in downloadPngScreenshot method; adds 'sog' file extension support
src/png-exporter.ts Improves async handling by moving lodepng initialization outside the message handler
rollup.config.mjs Simplifies build configuration by consolidating engine path logic and removing unused PCUI variables
package.json Updates multiple dependencies to latest versions including TypeScript, ESLint, and PlayCanvas

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread rollup.config.mjs Outdated
@slimbuck slimbuck changed the title Update deps Update engine Sep 3, 2025
@slimbuck slimbuck merged commit cb2385e into main Sep 3, 2025
2 checks passed
@slimbuck slimbuck deleted the update-deps branch September 3, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants