Skip to content

[Not For Merge]: compiling the library code with React compiler#3246

Draft
sanjaiyan-dev wants to merge 3 commits intopmndrs:mainfrom
sanjaiyan-dev:sanjaiyan-react-compiler
Draft

[Not For Merge]: compiling the library code with React compiler#3246
sanjaiyan-dev wants to merge 3 commits intopmndrs:mainfrom
sanjaiyan-dev:sanjaiyan-react-compiler

Conversation

@sanjaiyan-dev
Copy link
Copy Markdown

Description:
This PR integrates the React Compiler to align the framework with modern React standards and improve overall performance.

Key Benefits:

Check List

  • pnpm run fix for formatting and linting code and docs

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
jotai Ready Ready Preview, Comment Mar 6, 2026 2:29pm

Request Review

@dai-shi
Copy link
Copy Markdown
Member

dai-shi commented Mar 1, 2026

I'll consider this seriously but not immediately. In the meantime, would anyone like to benchmark the performance difference? Please open a new discussion.

Based on the results, we'll consider when to introduce it.

Closing until then.

@dai-shi dai-shi closed this Mar 1, 2026
@dai-shi
Copy link
Copy Markdown
Member

dai-shi commented Mar 4, 2026

not immediately

This basically requires react 19 and up. https://react.dev/reference/react-compiler/configuration#version-compatibility
Jotai v3 will support react 18 and up, so the target of this is Jotai v4.

@sanjaiyan-dev
Copy link
Copy Markdown
Author

not immediately

This basically requires react 19 and up. https://react.dev/reference/react-compiler/configuration#version-compatibility Jotai v3 will support react 18 and up, so the target of this is Jotai v4.

Hi, React Compiler supports React 19 and is backward compatible with React 18 and React 17. Please refer to https://react.dev/reference/react-compiler/compiling-libraries#backwards-compatibility for more details. Thank you.

@dai-shi
Copy link
Copy Markdown
Member

dai-shi commented Mar 5, 2026

I don't love using "react-compiler-runtime" with React 19.

In the mean time, would you like to benchmark the performance difference? Please open a new discussion.

@sanjaiyan-dev
Copy link
Copy Markdown
Author

I don't love using "react-compiler-runtime" with React 19.

In the mean time, would you like to benchmark the performance difference? Please open a new discussion.

Sure I will 🤝

@sanjaiyan-dev
Copy link
Copy Markdown
Author

#3255

@dai-shi

@dai-shi dai-shi reopened this Mar 5, 2026
@dai-shi dai-shi marked this pull request as draft March 5, 2026 23:50
@dai-shi dai-shi changed the title chore(compiler): add support for React compiler 🚀 [Not For Merge]: compiling the library code with React compiler Mar 5, 2026
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Mar 6, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 6, 2026

More templates

npm i https://pkg.pr.new/jotai@3246

commit: 6a7eec4

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2026

LiveCodes Preview in LiveCodes

Latest commit: 1e96835
Last updated: Mar 6, 2026 2:28pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/8KTBYBUBT

See documentations for usage instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants