breaking(internals): iterative batched invalidateDependents (scale)#3283
Open
dmaskasky wants to merge 1 commit intopmndrs:mainfrom
Open
breaking(internals): iterative batched invalidateDependents (scale)#3283dmaskasky wants to merge 1 commit intopmndrs:mainfrom
dmaskasky wants to merge 1 commit intopmndrs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/EDJMKNU8Z |
See documentations for usage instructions.
dmaskasky
changed the title
dmaskasky
changed the title
dmaskasky
force-pushed
the
iterative-batched-invalidate-dependents-experiment
branch
from
3919ab8 to
2d3a5d4
Compare
dmaskasky
force-pushed
the
iterative-batched-invalidate-dependents-experiment
branch
from
2d3a5d4 to
f0c0226
Compare
dmaskasky
changed the title
dmaskasky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invalidateDependents is called inside a for loop in mountDependencies. InvalidateDependents involves deeply traversing dependents. To help improve performance, this PR moved invalidateDependents out of the for loop and changes the invalidateDependents api to accept a list of atoms.
The breaking change is changing invalidateDependents to accept atom list.
Check List
pnpm run fixfor formatting and linting code and docs