Skip to content

fix(internals): check if atom has dependencies before doing mountDependencies work (performance)#3290

Open
dmaskasky wants to merge 1 commit intopmndrs:mainfrom
dmaskasky:mount-dependencies-condition
Open

fix(internals): check if atom has dependencies before doing mountDependencies work (performance)#3290
dmaskasky wants to merge 1 commit intopmndrs:mainfrom
dmaskasky:mount-dependencies-condition

Conversation

@dmaskasky
Copy link
Copy Markdown
Collaborator

@dmaskasky dmaskasky commented Apr 1, 2026

Summary

Check if atom as dependencies before doing mountDependencies work.

Check List

  • pnpm run fix for formatting and linting code and docs

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
jotai Ready Ready Preview, Comment Apr 1, 2026 8:01pm

Request Review

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Apr 1, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

LiveCodes Preview in LiveCodes

Latest commit: fcb8c36
Last updated: Apr 1, 2026 8:00pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/D7FP59MC3

See documentations for usage instructions.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 1, 2026

More templates

npm i https://pkg.pr.new/jotai@3290

commit: fcb8c36

Copy link
Copy Markdown
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I would like to merge this after we decide how to do with building blocks.

@dmaskasky dmaskasky changed the title check if atom as dependencies before doing mountDependencies work check if atom has dependencies before doing mountDependencies work Apr 1, 2026
@dmaskasky dmaskasky changed the title check if atom has dependencies before doing mountDependencies work fix(internals): check if atom has dependencies before doing mountDependencies work (performance) Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants