Reset Pointer to Interaction Model Engine on Shutdown#37958
Merged
mergify[bot] merged 2 commits intoproject-chip:masterfrom Apr 28, 2026
Merged
Reset Pointer to Interaction Model Engine on Shutdown#37958mergify[bot] merged 2 commits intoproject-chip:masterfrom
mergify[bot] merged 2 commits intoproject-chip:masterfrom
Conversation
Reset the member variable pointer to the Interaction Model Engine when the Checkin Handler is shutdown.
Contributor
Author
|
@witowsg-amazon Hello! I am sorry for such a minor suggested change. I am not even 100% sure that it should be included. But, I thought I would offer it anyways. If it is something that needs to be included, I am more than happy to add unit tests in the appropriate spot. Thank you for all the work that you are doing on this SDK! |
|
PR #37958: Size comparison from b56134c to 6fa559b Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Mar 11, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
|
andy31415
approved these changes
Apr 27, 2026
andy31415
added
the
sdk-maintainer-approved
Contributor
|
Seems reasonable to me given that init sets it. CI will validate if we have odd edge cases (we should not have any) |
|
PR #37958: Size comparison from 46582e0 to 8d58d18 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37958 +/- ##
=======================================
Coverage 54.52% 54.52%
=======================================
Files 1588 1588
Lines 108571 108572 +1
Branches 13365 13365
=======================================
+ Hits 59203 59204 +1
Misses 49368 49368 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thanks for approving!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset the member variable pointer to the Interaction Model Engine when the Checkin Handler is shutdown.
Testing
WIP