[CameraAVSM] SDK XML and zap changes for Spec update of new ImageRotation attribute#43477
Open
pidarped wants to merge 6 commits intoproject-chip:masterfrom
Open
[CameraAVSM] SDK XML and zap changes for Spec update of new ImageRotation attribute#43477pidarped wants to merge 6 commits intoproject-chip:masterfrom
pidarped wants to merge 6 commits intoproject-chip:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ImageRotationDiscreteAngles attribute to the Camera AV Stream Management cluster. The changes primarily involve updating the ZCL XML definition, which also bumps the cluster revision to 2, and subsequently regenerating code across various platforms including C++, Java, Kotlin, Python, and Objective-C. The changes appear to be correctly propagated to all generated files. After a thorough review, I have not identified any issues that require changes.
|
PR #43477: Size comparison from 86c4366 to 0ed660f Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43477 +/- ##
==========================================
- Coverage 54.25% 54.17% -0.08%
==========================================
Files 1563 1574 +11
Lines 107454 108110 +656
Branches 13334 13429 +95
==========================================
+ Hits 58294 58569 +275
- Misses 49160 49541 +381 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CameraAVStreamManagement cluster data model and regenerated bindings to reflect the addition of the ImageRotationDiscreteAngles attribute (and corresponding cluster revision bump) across chip-tool, Darwin, Java/Kotlin, and Python controller layers.
Changes:
- Adds
ImageRotationDiscreteAngles(0x0029 / 41) attribute plumbing across generated command, logging, metadata, and accessor layers. - Bumps CameraAVStreamManagement cluster revision from 1 to 2 in generated metadata and controller data model.
- Updates generated controller bindings for Darwin, Java/Kotlin, and Python to read/write/subscribe/decode the new attribute.
Reviewed changes
Copilot reviewed 24 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| zzz_generated/darwin-framework-tool/zap-generated/cluster/Commands.h | Adds read/write/subscribe commands for the new attribute in the Darwin framework tool CLI bindings. |
| zzz_generated/chip-tool/zap-generated/cluster/logging/EntryToText.cpp | Adds attribute-id-to-name mapping for logging. |
| zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.cpp | Adds decoding/logging support for the new attribute value. |
| zzz_generated/chip-tool/zap-generated/cluster/Commands.h | Adds chip-tool read/write/subscribe command registration for the new attribute. |
| zzz_generated/app-common/clusters/CameraAvStreamManagement/MetadataProvider.h | Adds metadata provider mapping for the new attribute. |
| zzz_generated/app-common/clusters/CameraAvStreamManagement/Metadata.h | Bumps cluster revision and adds attribute metadata entry. |
| zzz_generated/app-common/clusters/CameraAvStreamManagement/Attributes.ipp | Adds TLV decode dispatch for the new attribute. |
| zzz_generated/app-common/clusters/CameraAvStreamManagement/Attributes.h | Adds attribute TypeInfo and DecodableType field for the new attribute. |
| zzz_generated/app-common/clusters/CameraAvStreamManagement/AttributeIds.h | Adds the new attribute ID and increments attribute count. |
| zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.h | Declares a getter accessor for the new attribute. |
| zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp | Implements getter accessor for the new attribute. |
| src/darwin/Framework/CHIP/zap-generated/MTRClusters.mm | Adds Objective-C cluster read/write methods for the new attribute. |
| src/darwin/Framework/CHIP/zap-generated/MTRClusters.h | Declares Objective-C cluster read/write methods for the new attribute. |
| src/darwin/Framework/CHIP/zap-generated/MTRClusterNames.mm | Adds attribute name lookup for the new Darwin constant. |
| src/darwin/Framework/CHIP/zap-generated/MTRClusterConstants.h | Adds the new attribute ID constant. |
| src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.mm | Adds base cluster read/write/subscribe implementations for the new attribute. |
| src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h | Declares base cluster read/write/subscribe APIs for the new attribute. |
| src/darwin/Framework/CHIP/zap-generated/MTRAttributeTLVValueDecoder.mm | Adds TLV decoding for the new attribute to NSNumber. |
| src/darwin/Framework/CHIP/zap-generated/MTRAttributeSpecifiedCheck.mm | Marks the new attribute as specified for the cluster. |
| src/controller/python/matter/clusters/Objects.py | Adds the attribute to the Python cluster object model. |
| src/controller/python/matter/clusters/CHIPClusters.py | Adds the attribute metadata to the Python controller cluster map. |
| src/controller/java/zap-generated/CHIPAttributeTLVValueDecoder.cpp | Adds TLV decode support for the new attribute in the Java controller JNI decoder. |
| src/controller/java/generated/java/matter/controller/cluster/clusters/CameraAvStreamManagementCluster.kt | Adds Kotlin read/write/subscribe APIs for the new attribute. |
| src/controller/java/generated/java/chip/devicecontroller/ClusterWriteMapping.java | Adds write-attribute mapping for the new attribute. |
| src/controller/java/generated/java/chip/devicecontroller/ClusterReadMapping.java | Adds read-attribute mapping for the new attribute. |
| src/controller/java/generated/java/chip/devicecontroller/ClusterIDMapping.java | Adds enum entry for the new attribute ID. |
| src/controller/java/generated/java/chip/devicecontroller/ChipClusters.java | Adds Java read/write/subscribe methods for the new attribute. |
| src/controller/data_model/controller-clusters.matter | Bumps cluster revision and adds the new attribute to the controller data model. |
| src/app/zap-templates/zcl/data-model/chip/camera-av-stream-management-cluster.xml | Updates the generated cluster XML to revision 2 and defines the new attribute. |
You can also share your feedback on Copilot code review. Take the survey.
pidarped
force-pushed
the
SpecChangesAVSM
branch
from
0ed660f to
cd27dd9
Compare
|
PR #43477: Size comparison from e3deda9 to cd27dd9 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43477: Size comparison from e3deda9 to aed529e Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43477: Size comparison from e3deda9 to 0e9359b Increases above 0.2%:
Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
marktrayer
reviewed
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XML and code-gen changes for new attribute ImageRotationDiscreteAngles.
Testing
CI validation
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines