[DO NOT REVIEW] Update ZAP XML for Thermostat#43624
Closed
AryaHassanli wants to merge 7 commits intoproject-chip:masterfrom
Closed
[DO NOT REVIEW] Update ZAP XML for Thermostat#43624AryaHassanli wants to merge 7 commits intoproject-chip:masterfrom
AryaHassanli wants to merge 7 commits intoproject-chip:masterfrom
Conversation
+ Regen ZAP
github-actions
Bot
added
examples
darwin
controller
app
examples chef
pullapprove
Bot
added
review - pending
and removed
examples
darwin
controller
app
examples chef
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ZAP XML definition for the Thermostat cluster and regenerates all associated files. The changes primarily involve removing deprecated weekly schedule-related features and attributes, updating the cluster revision, and modifying the properties of several other attributes. The changes have been propagated across all relevant generated source code files for various platforms (Java, Kotlin, Python, C++, Objective-C). The changes appear consistent with an automated regeneration. Per the repository's style guide, which advises against commenting on generated files, XML, and .matter files, I have no specific comments on the code changes.
|
PR #43624: Size comparison from 3a725ca to 53cf72b Full report (3 builds for realtek, stm32)
|
github-actions
Bot
added
examples
darwin
controller
app
examples chef
|
PR #43624: Size comparison from 3a725ca to 5278c1b Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
|
PR #43624: Size comparison from 3a725ca to 96c07ea Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
|
PR #43624: Size comparison from 3a725ca to 9e7699b Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
|
PR #43624: Size comparison from 3a725ca to 99e8f00 Full report (8 builds for cc32xx, nrfconnect, qpg, realtek, stm32)
|
|
PR #43624: Size comparison from 3a725ca to 7de3759 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43624 +/- ##
==========================================
+ Coverage 54.07% 54.12% +0.04%
==========================================
Files 1548 1551 +3
Lines 106709 106955 +246
Branches 13308 13313 +5
==========================================
+ Hits 57704 57888 +184
- Misses 49005 49067 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AryaHassanli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update ZAP XML of Thermostat Cluster(src/app/zap-templates/zcl/data-model/chip/thermostat-cluster.xml) using:
The above list of attributes are the tags approved for v1.6 at 0.9.
Remove support in src
The following files were updated to remove support of obsolete commands and features:
Regenerate ZAP files using:
Related issues
#43487
This is the second PR of 3 PRs to fix the above issue.
Testing
CI test is enough.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines