[1.5][ACL] version should be 2 instead of 3 for access-control-cluster.xml #43650
Merged
andy31415 merged 2 commits intoproject-chip:v1.5-branchfrom Mar 25, 2026
Merged
Conversation
github-actions
Bot
added
examples
controller
app
examples chef
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the cluster revision for the Access Control cluster from 3 to 2, citing specification alignment. The change is consistently applied across a large number of example application data models (.matter files), the core cluster definition XML, the controller data model, and the corresponding generated C++ header file. The changes are systematic and align with the stated purpose of the pull request.
|
PR #43650: Size comparison from 308d138 to 580bdc5 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version should be 2 instead of 3 for access-control-cluster.xml per spec
Related issues
N/A
Testing
local testing
Readability checklist
N/A