Update thermostat zap by errata#43671
Merged
mergify[bot] merged 6 commits intoproject-chip:masterfrom Mar 25, 2026
Merged
Conversation
github-actions
Bot
added
examples
darwin
controller
app
examples chef
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Thermostat cluster (ID 513) to revision 11. Key changes include making several attributes (HVACSystemTypeConfiguration, thermostatProgrammingOperationMode, occupiedSetback, unoccupiedSetback, and their min/max variants) read-only or deprecated. Additionally, parameters for weekly schedule commands (SetWeeklySchedule, GetWeeklySchedule, ClearWeeklySchedule) are now optional, and the GetWeeklySchedule command no longer returns a response payload. Command descriptions and internal code generation metadata have also been updated across various generated files.
|
PR #43671: Size comparison from 4428cc9 to 13fe281 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43671 +/- ##
=======================================
Coverage 54.11% 54.11%
=======================================
Files 1553 1553
Lines 107104 107104
Branches 13328 13328
=======================================
Hits 57957 57957
Misses 49147 49147 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AryaHassanli
changed the title
andy31415
reviewed
Mar 25, 2026
andy31415
reviewed
Mar 25, 2026
andy31415
reviewed
Mar 25, 2026
|
PR #43671: Size comparison from 4428cc9 to 25fbc2a Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
AryaHassanli
force-pushed
the
update-thermostat-zap-by-errata
branch
from
25fbc2a to
28a2cd2
Compare
|
PR #43671: Size comparison from 740b218 to 28a2cd2 Full report (17 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, realtek, stm32)
|
Contributor
Author
|
Thank you @andy31415 for your review. I addressed your comments by updating the errata. Could you please confirm if it's fixed now? |
|
PR #43671: Size comparison from 740b218 to c284dcd Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Mar 25, 2026
Contributor
andy31415
left a comment
andy31415
left a comment
There was a problem hiding this comment.
Diff seems ok: revision bumped and some max values lost, however I don't see any generated code differences for max showing up.
@AryaHassanli is max being dropped ok here?
Contributor
Author
Fixed! |
andy31415
approved these changes
Mar 25, 2026
Contributor
andy31415
left a comment
andy31415
left a comment
There was a problem hiding this comment.
Seems good now - I see we gained a few "min" values, however checking spec those are part of the constraints.
andy31415
added
the
sdk-maintainer-approved
|
PR #43671: Size comparison from 740b218 to bbce999 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
khodya
pushed a commit
to khodya/connectedhomeip
that referenced
this pull request
Apr 3, 2026
* Update zapxml handler to support fieldId for commands * Update ZAP xml * ZAP regen * ZAP Regen * Update missing constraints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update ZAP XML of Thermostat Cluster(src/app/zap-templates/zcl/data-model/chip/thermostat-cluster.xml) using:
The above list of attributes are the tags approved for v1.6 at 0.9.
Regenerate ZAP files using:
Related issues
Testing
CI test is enough.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines