[v1.6-sve-branch] several cherrypicks for groupcast support.#71636
Closed
andy31415 wants to merge 12 commits intoproject-chip:v1.6-sve-branchfrom
Closed
[v1.6-sve-branch] several cherrypicks for groupcast support.#71636andy31415 wants to merge 12 commits intoproject-chip:v1.6-sve-branchfrom
andy31415 wants to merge 12 commits intoproject-chip:v1.6-sve-branchfrom
Conversation
* Move macro definition * Restyled by gn * Move silabs gni macro definition * Enable groupcast in wifi args gni file for silabs example * Poke CI * Revert "Poke CI" This reverts commit b6e29e1. --------- Co-authored-by: Restyled.io <commits@restyled.io>
…test steps (project-chip#71371) * Add a step to verify DUT SpecificationVersion before running the new test steps for 1.6 and above * Apply suggestion to avoid failure in case SpecificationVersion is not present on DUT with version pre 1.3
…ject-chip#71439) * Update Light-switch zap file to add groupcast has sender * Enable the gn arg chip_config_enable_groupcast on gn built apps * Restyled by gn * Add chip_config_enable_groupcast gn args to cmake builds. and enable on light-switch * Add manual step instructions/details in two nont automated binding tests. * Fix arg name --------- Co-authored-by: Restyled.io <commits@restyled.io>
…upcast devices (project-chip#71394) * TC-SC-5.2: Fix PICS, run for whole node The groups tests are weird because they're running against the endpoint with the groups cluster, which is not the endpoint with the key management cluster. With the top level PICS the way they are, this test wouldn't be selected reliably. Instead, swapping to have the test do the endpoint selection logic itself. This should be run once per node for any commissionable device. If there are no groups endpoints, then it's fine - this test will skip all the steps and return. * TC-SC-5.1: Same fix as TC-SC-5.2 * TC-SC-5.2: Fix test for non-groupcast * Address review comments * Restyled by autopep8 * remove pixit notation * Fix endpoint per review comment * Consolidate endpoint selection, update comment * Restyled by autopep8 --------- Co-authored-by: Restyled.io <commits@restyled.io>
* [WIP] Test plan impl * Restyled by ruff * Restyled by autopep8 * minor update * Restyled by ruff * Fix step ordering errors * test runs w/ groupcast, needs cleanup * Restyled by autopep8 * Restyled by isort * lint error * Cleanup, still some todo's remaining * Restyled by ruff * Restyled by autopep8 * Support iana and per group, fix legacy groups flow * Add run without groupcast and pics update * Remove old yaml version of test * Restyled by ruff --------- Co-authored-by: Restyled.io <commits@restyled.io>
…1515) * Fix key and AuxACL update checks in Groupcast cluster - Disallow touching keys or useAuxiliaryACL from Manage-privilege commands UpdateGroupKey and JoinGroup, to avoid privilege escalation. - Disallow touching the IPK. - Disallow GroupID 0. Addresses fixes in the following spec PRs: - CHIP-Specifications/connectedhomeip-spec#12865 - CHIP-Specifications/connectedhomeip-spec#12868 Testing done: - Added full unit test coverage. - Fixed test plumbing to better enable actual testing of these types of situation. * Restyled * Address review comment about factoring * Restyled by clang-format * Add more coverage to ReplaceEndpoints argument of JoinGroup * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Add logging, general cleanup, todos * Add code to search for valid cluster with operate priv commands * Fix command possibly being response type and unbound value todo * Restyled by ruff * Restyled by autopep8 * Restyled by isort * Address comment --------- Co-authored-by: Restyled.io <commits@restyled.io>
* enable gc_2_2 and gc_2_7 in CI * update CI endpoint argument from 1 to 0
* Roll back to groups cluster rev4. Revision 5 implementation was done in time for SVE * run regen all
github-actions
bot
added
examples
scripts
lib
controller
app
config
tests
core
examples chef
andy31415
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables the Groupcast cluster across multiple platforms and example applications, integrating it with the access control system to enforce administrative privileges for sensitive operations. The changes include logic updates to cluster commands, comprehensive test enhancements, and a reversion of the Groups cluster revision to 4. I have no feedback to provide.
s07641069
approved these changes
Apr 17, 2026
|
PR #71636: Size comparison from 17fd735 to dff5656 Increases above 0.2%:
Full report (42 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.6-sve-branch #71636 +/- ##
===================================================
+ Coverage 54.25% 54.26% +0.01%
===================================================
Files 1563 1563
Lines 107441 107457 +16
Branches 13333 13331 -2
===================================================
+ Hits 58287 58310 +23
+ Misses 49154 49147 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Abandoning: apparently there are more things to CP, so I will do that instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on a list received from @tennessee-google, cherrypicks for:
#43765
#71371
#71450
#71439
#71394
#71452
#43731
#71490
#71515
#71546
#71551
#71562
#71572
Conflicts:
Cherrypicking #71439 conflicted with #71582. I updated BIND_2_2 and BIND_2_3 yaml to match the CP since I assumed more correct (matched master)
Cherrypicking #71452 conflicted in tests.yaml, seems like a indent issue only
Cherrypicking #71551 conflicted in run header in TC_SC_5_1 and TC_SC_5_2. I did not add the new headers (but this needs to be double-checked for consistency still)
Testing
Cherrypicks were mostly clean (except above notes). CI will also validate.