[Fix] Fix webOS's bluetooth overflow problem#71761
Open
jungwook-park wants to merge 1 commit intoproject-chip:masterfrom
Open
[Fix] Fix webOS's bluetooth overflow problem#71761jungwook-park wants to merge 1 commit intoproject-chip:masterfrom
jungwook-park wants to merge 1 commit intoproject-chip:masterfrom
Conversation
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the _HexToBytes function in WbsDeviceScanner.cpp to include destination size validation and ensure the output buffer is zero-initialized for unused bytes. Feedback suggests optimizing the implementation by decoding directly into the destination buffer, thereby eliminating unnecessary heap allocation and memory copying. Additionally, the reviewer noted that braces should be used for all if statements to maintain consistency with the existing codebase style.
jungwook-park
force-pushed
the
fix-webos-overflow
branch
from
c79a20c to
3939be3
Compare
|
PR #71761: Size comparison from adb9376 to 3939be3 Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
andy31415
reviewed
Apr 24, 2026
andy31415
reviewed
Apr 24, 2026
jungwook-park
force-pushed
the
fix-webos-overflow
branch
2 times, most recently
from
3e63f7d to
2faa263
Compare
detailed: Prevent overflow lisk
jungwook-park
force-pushed
the
fix-webos-overflow
branch
from
2faa263 to
2428d8a
Compare
|
PR #71761: Size comparison from 6bf5656 to 2428d8a Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #71761 +/- ##
==========================================
+ Coverage 54.50% 54.52% +0.02%
==========================================
Files 1588 1588
Lines 112392 108572 -3820
Branches 13521 13365 -156
==========================================
- Hits 61264 59204 -2060
+ Misses 51128 49368 -1760 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
Fixes #71760
Testing
Manually verified rejection of oversized serviceData and confirmed normal Matter BLE advertisements are still parsed correctly.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable: