[Ameba] add support for ConfigurationVersion and Groupcast#71820
Open
pankore wants to merge 1 commit intoproject-chip:masterfrom
Open
[Ameba] add support for ConfigurationVersion and Groupcast#71820pankore wants to merge 1 commit intoproject-chip:masterfrom
pankore wants to merge 1 commit intoproject-chip:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds groupcast support to the Ameba all-clusters, light-switch, and lighting applications and implements configuration versioning in the Ameba platform. The review identifies a critical issue where initParams.groupDataProvider is dereferenced before being initialized, which would lead to a crash. It also recommends including the missing GroupDataProviderImpl.h header to facilitate the necessary initialization.
|
PR #71820: Size comparison from 6bf5656 to c30525c Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
* added implementation for ConfigurationVersion. * added code to support and initialize groupcast.
pankore
force-pushed
the
ameba_update_260428
branch
from
c30525c to
4ba0078
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #71820 +/- ##
=======================================
Coverage 54.52% 54.52%
=======================================
Files 1588 1588
Lines 108569 108572 +3
Branches 13365 13365
=======================================
+ Hits 59201 59204 +3
Misses 49368 49368 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
N/A
Testing
Verified with v1.6 TH. Tested using CLI-PYTHON TC-BINFO-3.2 and all CLI-PYTHON TC-GC test cases; all results passed.