Skip to content

Add pybammsolvers nonlinear solver #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcBerliner merged 34 commits into from
Apr 29, 2026

Merge branch 'nonlinear-solver' of https://github.com/pybamm-team/PyB…

f6a6248
Select commit
Loading
Failed to load commit list.
Merged

Add pybammsolvers nonlinear solver #5459

Merge branch 'nonlinear-solver' of https://github.com/pybamm-team/PyB…
f6a6248
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 29, 2026 in 1s

98.25% (-0.05%) compared to 208320d

View this Pull Request on Codecov

98.25% (-0.05%) compared to 208320d

Details

Codecov Report

❌ Patch coverage is 93.12169% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.25%. Comparing base (208320d) to head (f6a6248).

Files with missing lines Patch % Lines
src/pybamm/solvers/nonlinear_solver.py 95.79% 5 Missing ⚠️
src/pybamm/solvers/idaklu_solver.py 90.00% 4 Missing ⚠️
src/pybamm/solvers/base_solver.py 85.71% 3 Missing ⚠️
src/pybamm/solvers/algebraic_solver.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5459      +/-   ##
==========================================
- Coverage   98.29%   98.25%   -0.05%     
==========================================
  Files         337      338       +1     
  Lines       30950    31115     +165     
==========================================
+ Hits        30423    30571     +148     
- Misses        527      544      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov