Skip to content

Clean up skills discovery and claude files#53682

Open
maxandersen wants to merge 1 commit intoquarkusio:mainfrom
maxandersen:cleanagent
Open

Clean up skills discovery and claude files#53682
maxandersen wants to merge 1 commit intoquarkusio:mainfrom
maxandersen:cleanagent

Conversation

@maxandersen
Copy link
Copy Markdown
Member

This removes the explicit call out of skills from agents.md/claude.md
as the skills aren't meant to force included but rather looked up when
need that skill.

The skills were not as is actually available to claude as it wont look
in .agents/skills only .claude/skills. Other agents handles .agents/skills just fine.

Thus testing with pi.dev, cursor and claude I went with symoblic linking
.claude so Claude is not "blind" to the skills.

Also added a .local folder to .gitignore as convention for
storing personal .local plan/notes/agents.md etc.

This removes the explicit call out of skills from agents.md/claude.md
as the skills aren't meant to force included but rather looked up when
need that skill.

The skills were not as is actually available to claude as it wont look
in .agents/skills only .claude/skills. Other agents handles .agents/skills just fine.

Thus testing with pi.dev, cursor and claude I went with symoblic linking
.claude so Claude is not "blind" to the skills.

Also added a .local folder to .gitignore as convention for
storing personal .local plan/notes/agents.md etc.
@quarkus-bot
Copy link
Copy Markdown

quarkus-bot bot commented Apr 17, 2026

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4bd3925.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Devtools Tests - JDK 25 Semeru

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testExampleCodestartsJava(String)[5] - History

  • expected: 0 but was: 1 - org.opentest4j.AssertionFailedError
Details
org.opentest4j.AssertionFailedError: 

expected: 0
 but was: 1
	at io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.generateProjectRunTests(QuarkusCodestartBuildIT.java:138)
	at io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.generateProjectRunTests(QuarkusCodestartBuildIT.java:117)
	at io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testExampleCodestartsJava(QuarkusCodestartBuildIT.java:100)

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testExampleCodestartsJava(String)[5] - History

  • expected: 0 but was: 1 - org.opentest4j.AssertionFailedError
Details
org.opentest4j.AssertionFailedError: 

expected: 0
 but was: 1
	at io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.generateProjectRunTests(QuarkusCodestartBuildIT.java:138)
	at io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.generateProjectRunTests(QuarkusCodestartBuildIT.java:117)
	at io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testExampleCodestartsJava(QuarkusCodestartBuildIT.java:100)

⚙️ JVM Integration Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
Details
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Integration Tests - JDK 25 Semeru

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testPrices - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <3> but was: <6> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
Details
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <3> but was: <6> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testPrices(KafkaConnectorTest.java:77)
Caused by: org.opentest4j.AssertionFailedError: expected: <3> but was: <6>
  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <15> but was: <6> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
Details
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <15> but was: <6> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testPrices(KafkaConnectorTest.java:77)
Caused by: org.opentest4j.AssertionFailedError: expected: <15> but was: <6>

io.quarkus.it.kafka.KafkaConnectorTest.testRequestReply - History

  • iterable contents differ at index [0], expected: <reply-1> but was: <{"details":"Error id fc938501-7147-4b3b-bbf2-896c402556c7-1, org.jboss.resteasy.spi.UnhandledException: io.smallrye.reactive.messaging.kafka.reply.KafkaRequestReplyTimeoutException: Timeout waiting for a reply for request with correlation ID: a341d265-d527-42e0-8280-2e153f5ccda6","stack":"org.jboss.resteasy.spi.UnhandledException: io.smallrye.reactive.messaging.kafka.reply.KafkaRequestReplyTimeoutException: Timeout waiting for a reply for request with correlation ID: a341d265-d527-42e0-8280-2e153f5ccda6\n\tat org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:107)\n\tat org.jboss.resteasy.core.ExceptionHandler.handleException(ExceptionHandler.java:344)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.writeException(SynchronousDispatcher.java:205)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:452)\n\tat org.jboss.resteasy.core.Synchron... - org.opentest4j.AssertionFailedError
Details
org.opentest4j.AssertionFailedError: iterable contents differ at index [0], expected: <reply-1> but was: <{"details":"Error id fc938501-7147-4b3b-bbf2-896c402556c7-1, org.jboss.resteasy.spi.UnhandledException: io.smallrye.reactive.messaging.kafka.reply.KafkaRequestReplyTimeoutException: Timeout waiting for a reply for request with correlation ID: a341d265-d527-42e0-8280-2e153f5ccda6","stack":"org.jboss.resteasy.spi.UnhandledException: io.smallrye.reactive.messaging.kafka.reply.KafkaRequestReplyTimeoutException: Timeout waiting for a reply for request with correlation ID: a341d265-d527-42e0-8280-2e153f5ccda6\n\tat org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:107)\n\tat org.jboss.resteasy.core.ExceptionHandler.handleException(ExceptionHandler.java:344)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.writeException(SynchronousDispatcher.java:205)\n\tat org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:452)\n...

@maxandersen maxandersen changed the title fix: clean up skills discovery and claude files Clean up skills discovery and claude files Apr 18, 2026
Comment thread .claude
@@ -0,0 +1 @@
.agents/ No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Claude Code writes settings through the symlink into .agents/, those files become visible to git and could be committed. Maybe add .agents/settings*.json to .gitignore ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants