Fix nested list handling in Javadoc to AsciiDoc converter#53689
Open
kyooosukedn wants to merge 1 commit intoquarkusio:mainfrom
Open
Fix nested list handling in Javadoc to AsciiDoc converter#53689kyooosukedn wants to merge 1 commit intoquarkusio:mainfrom
kyooosukedn wants to merge 1 commit intoquarkusio:mainfrom
Conversation
The JavadocToAsciidocTransformer previously flattened all nested HTML lists (<ul>/<ol>) to the same level, using the same marker for all items. This resulted in incorrect AsciiDoc output where nested bullet lists were indistinguishable from top-level items. Changes: - Track list nesting depth in the Context class - Use AsciiDoc-standard nested list markers (* for unordered, . for ordered) repeated according to depth (e.g., ** for level 2, *** for level 3) - Strip leading whitespace from text nodes inside list items to handle HTML formatting artifacts - Avoid extra blank lines for nested lists - Add tests for nested unordered lists, nested ordered lists, deeply nested (3 levels) lists, and mixed nested lists (unordered containing ordered) Fixes quarkusio#50474
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #50474
The
JavadocToAsciidocTransformerpreviously flattened all nested HTML lists (<ul>/<ol>) to the same level, using the same marker for all items. This resulted in incorrect AsciiDoc output where nested bullet lists were indistinguishable from top-level items.Example
This Javadoc:
Before (flattened):
After (proper nesting):
Changes
Contextclass*for unordered,.for ordered) repeated according to depth (e.g.,**for level 2,***for level 3)parseJavaDocWithNestedUnorderedList- nested<ul>inside<ul>parseJavaDocWithNestedOrderedList- nested<ol>inside<ol>parseJavaDocWithDeeplyNestedLists- 3 levels of nestingparseJavaDocWithMixedNestedLists-<ol>inside<ul>