Fix false positive on couchdb enum check#21346
Open
adfoster-r7 wants to merge 1 commit intorapid7:masterfrom
Open
Fix false positive on couchdb enum check#21346adfoster-r7 wants to merge 1 commit intorapid7:masterfrom
adfoster-r7 wants to merge 1 commit intorapid7:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens CouchDB detection in couchdb_enum to avoid false positives during check when the target returns non-CouchDB responses (e.g., generic 404 HTML pages).
Changes:
- Make
get_versionfail closed unless the root endpoint returns HTTP 200. - Validate that the parsed JSON looks like CouchDB (expects a
couchdbkey) before accepting it. - Require a parsed
versionvalue before reporting a successful version fetch.
cdd96c7 to
6e992aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix false positive on couchdb enum check
Verification
Against not vulnerable, working as expected:
Against vulnerable (
docker run -p 5984:5984 couchdb:1.6.1) - working as expected: