Skip to content

Comment out payload size cache tests#21361

Merged
adfoster-r7 merged 1 commit intorapid7:masterfrom
sjanusz-r7:payload-cache-size-changes
Apr 22, 2026
Merged

Comment out payload size cache tests#21361
adfoster-r7 merged 1 commit intorapid7:masterfrom
sjanusz-r7:payload-cache-size-changes

Conversation

@sjanusz-r7
Copy link
Copy Markdown
Contributor

@sjanusz-r7 sjanusz-r7 commented Apr 22, 2026

This PR comments out (can remove) the specs related to payload cache size validation.
This caused us some woes in the past, and we are looking for an alternative approach with the Jenkins commits instead.

Verification

List the steps needed to make sure this thing works

  • Passing CI
  • Modify the CachedSize constant of any payload
  • Run bundle exec rspec spec/modules/payloads_spec.rb
  • Verify the tests do not fail.

Comment thread spec/support/shared/examples/payload_cached_size_is_consistent.rb
@sjanusz-r7 sjanusz-r7 force-pushed the payload-cache-size-changes branch from 69ea99a to 8587d1c Compare April 22, 2026 15:32
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Metasploit Kanban Apr 22, 2026
@adfoster-r7 adfoster-r7 merged commit aaf536d into rapid7:master Apr 22, 2026
18 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Metasploit Kanban Apr 22, 2026
@adfoster-r7 adfoster-r7 added the rn-no-release-notes no release notes label Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn-no-release-notes no release notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants