Open
Conversation
| let results = restrictChannels([], {query: {channel: 'foo'}}); | ||
| assert.deepEqual(results, []); | ||
| }); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
These tests may seem overkill, but I was very nervous about creating a security hole where external users could join a channel that wasn't whitelisted through the channel list provided to slackin.
Contributor
Author
|
Bump! |
|
I'd be super happy to benefit from this feature. Likewise, we have a community of projects and people sign up for different reasons. I think it would benefit to their onboarding experience to reach the expected channel(s). Is there anything to do to move this proposal forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #111.
At 18F, we often include something like the following in a project README:
Unfortunately, the latter direction often gets missed, and people end up joining the first channel listed. This pull request would allow the projects to link directly to their channel, avoiding the problem completely.
Instead of @mattgorecki's client-side solution, I opted to do the channel selection server-side so that they don't even see the dropdown:
Let me know what you think!
/cc @konklone