Update to PHP 8.0#76
Open
farktronix wants to merge 2 commits intoreceipt-print-hq:masterfrom
Open
Conversation
|
Reviewd it works well, thank you. Someone should really merge that. |
|
I can also add/confirm that this allowed me to use |
|
Hello @farktronix , is there any obstacle merging this PR? I can't use the library in my PHP8 software until it's merged, and I'd be super happy to do it :( Thanks in advance. |
Author
I don't have the ability to merge this myself, so it's just waiting on the project maintainer (@mike42) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
esc2htmlwith PHP v8.2.9 on MacOS I got some warnings and errors:It looks like the old
implode(array $array, string $separator): stringAPI was removed in PHP 8.0.0, but the fix is simple- just swap the arguments. I also fixed the warning about ${var} in strings being deprecated.I ran a code style check with
php vendor/bin/phpcs --standard=psr2 src/ -nbut got an error because php_codesniffer was out of date, so I bumped it up to^3.0