Merged
Conversation
…match, TEST_WORK_FOLDER propagation, and floating-point assertions
1c315fc to
da103f5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 935053f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As a continuation of #3724:
Fix flaky and broken integration tests
TEST_WORK_FOLDERto test targets. Locally,make startplaces TLS certs underwork/butTlsSettingsdefaultsTEST_WORK_FOLDERtowork/docker/. AddedTEST_WORK_FOLDER=$(REDIS_ENV_WORK_DIR)tomake testandmake test-coverageto align with the CI pipeline.assumeTruebefore truststore creation. The connectivity check was placed aftercreateAndSaveTestTruststorecalls, causing aRuntimeExceptioninstead of a graceful skip when stunnel is unavailable.standaloneWithOpenSsl. The test usedtruststoreFile0(redis-standalone-0) but connects to port 6443 which is served by redis-standalone-1. Changed totruststoreFile1to matchstandaloneWithJdkSsl.pexpireat.PEXPIREATuses an absolute JVM timestamp, soPTTLcan exceed the expected ceiling when the Redis server clock is slightly behind. Replaced the hardcoded upper bound with a dynamic calculation plus aclockSkewToleranceMstolerance.restoreReplace. Same issue withRestoreArgs.absttl()— applied the same dynamic upper bound fix. Aligned expiration to 5 seconds for consistency withpexpireat.hotkeysStartOptions. TheDURATIONtest section used the default sample ratio, which could skip the singleSETcommand. Addedsample(1)to ensure every command is captured, consistent withhotkeysBothMetrics.isCloseTofor similarity scores. Vector similarity scores can vary slightly across Redis versions and platforms. Replaced exactisEqualToassertions withisCloseTo(value, within(0.001)), consistent withRedisVectorSetAdvancedIntegrationTests.RedisClusterPubSubConnectionIntegrationTestsStatefulMultiDbConnectionIntegrationTestsMake sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Low Risk
Changes are limited to build/test harness and integration test assertions; main risk is accidentally masking real regressions by making expectations more permissive.
Overview
Reduces integration test flakiness by aligning
make test/make test-coveragewith the docker environment work directory (exportingTEST_WORK_FOLDER) so TLS artifacts are discovered consistently.Fixes SSL test setup by skipping early when stunnel is unavailable and correcting the OpenSSL test to use the truststore matching the target SSL endpoint.
Stabilizes several command tests by removing a brittle cluster pub/sub assertion, adding
HOTKEYSsampling to guarantee capture, making absolute-TTL assertions tolerant to clock skew, broadening expected failures in concurrent multi-DB tests, and using approximate comparisons for vector similarity scores.Reviewed by Cursor Bugbot for commit cbeb5f0. Bugbot is set up for automated code reviews on this repo. Configure here.