Conversation
cfd02b8 to
4cc1751
Compare
4cc1751 to
e07c000
Compare
|
@viceice if I merge this as-is, will this cause issues for other PRs? This looks like an existing coverage issue |
I don't think so, but can you fix the coverage issues with ignore and to-do comments? |
03cebf1 to
ebccee5
Compare
To provide better coverage for our users of what is a valid option for a `constraints` value, we can validate the overall format of the `constraints` block, as well as the given names of constraints. Where we have a Tool defined, we can use the default versioning for that Tool to validate the constraint's value. For now, both the validation of the `constraints`' value, and the validation of `constraints`' names will be a warning, but in the future may be made an error.
As this was renamed in #7308. It's been long enough since then that we can remove this check.
03a51d1 to
d2b20a3
Compare
For coverage fix, and also to provide insight when this does happen
d2b20a3 to
29dcd47
Compare
|
@viceice any help with this coverage? I can't seem to craft the right |
| }); | ||
| } | ||
| } else { | ||
| // v8 ignore next -- intentionally unhandled - if we knew what was to be covered here, we'd add validation |
There was a problem hiding this comment.
move before first if and use ignore else
There was a problem hiding this comment.
Seems to not like it
RahulGautamSingh
left a comment
There was a problem hiding this comment.
Shouldn't we also validate additionalConstraints values as well?
They're handled under We can't validate them further as they're not as well defined in terms of what the constraint should look like, |
Changes
To provide better coverage for our users of what is a valid option for a
constraintsvalue, we can validate the overall format of theconstraintsblock, as well as the given names of constraints.Where we have a Tool defined, we can use the default versioning for that
Tool to validate the constraint's value.
For now, both the validation of the
constraints' value, and thevalidation of
constraints' names will be a warning, but in the futuremay be made an error.
Context
Please select one of the below:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: