Skip to content

feat(manager/gomod): improve commitMessageTopic for go/toolchain directive bumps #42891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamietanna wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

feat(manager/gomod): improve commitMessageTopic for go/toolchain directive bumps #42891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/modules/manager/gomod/extract.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ describe('modules/manager/gomod/extract', () => {
currentValue: '1.23',
datasource: 'golang-version',
versioning: 'go-mod-directive',
commitMessageTopic: 'go module directive',
},
{
managerData: {
Expand Down Expand Up @@ -143,6 +144,7 @@ describe('modules/manager/gomod/extract', () => {
currentValue: '1.25.5',
datasource: 'golang-version',
versioning: 'go-mod-directive',
commitMessageTopic: 'go module directive',
},
{
managerData: {
Expand Down Expand Up @@ -212,6 +214,7 @@ describe('modules/manager/gomod/extract', () => {
currentValue: '1.23',
datasource: 'golang-version',
versioning: 'go-mod-directive',
commitMessageTopic: 'go module directive',
},
{
managerData: {
Expand All @@ -221,6 +224,7 @@ describe('modules/manager/gomod/extract', () => {
depType: 'toolchain',
currentValue: '1.23.3',
datasource: 'golang-version',
commitMessageTopic: 'go toolchain directive',
},
{
managerData: {
Expand Down Expand Up @@ -422,6 +426,7 @@ describe('modules/manager/gomod/extract', () => {
currentValue: '1.19',
datasource: 'golang-version',
versioning: 'go-mod-directive',
commitMessageTopic: 'go module directive',
},
{
managerData: {
Expand Down
4 changes: 4 additions & 0 deletions lib/modules/manager/gomod/line-parser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ describe('modules/manager/gomod/line-parser', () => {
depName: 'go',
depType: 'golang',
versioning: 'go-mod-directive',
commitMessageTopic: 'go module directive',
});
});

Expand All @@ -27,6 +28,7 @@ describe('modules/manager/gomod/line-parser', () => {
depType: 'golang',
skipReason: 'invalid-version',
versioning: 'go-mod-directive',
commitMessageTopic: 'go module directive',
});
});

Expand All @@ -39,6 +41,7 @@ describe('modules/manager/gomod/line-parser', () => {
depName: 'go',
depType: 'toolchain',
skipReason: 'invalid-version',
commitMessageTopic: 'go toolchain directive',
});
});

Expand All @@ -51,6 +54,7 @@ describe('modules/manager/gomod/line-parser', () => {
depName: 'go',
depType: 'toolchain',
skipReason: 'invalid-version',
commitMessageTopic: 'go toolchain directive',
});
});

Expand Down
2 changes: 2 additions & 0 deletions lib/modules/manager/gomod/line-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export function parseLine(input: string): PackageDependency | null {
depType: 'golang',
depName: 'go',
currentValue,
commitMessageTopic: 'go module directive',
};

if (!semver.validRange(currentValue)) {
Expand All @@ -69,6 +70,7 @@ export function parseLine(input: string): PackageDependency | null {
depType: 'toolchain',
depName: 'go',
currentValue,
commitMessageTopic: 'go toolchain directive',
};

if (!semver.valid(currentValue)) {
Expand Down
Loading