Open
Conversation
This commit modifies the CI configuration so that the containers that are built are actually manifest lists with images for multiple architectures, not just AMD64. This is helpful for modern clouds and hybrid clusters, where it's possible that not all machines are AMD64. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
|
I desperately needed the s3_exporter for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modifies the CI configuration so that the containers that
are built are actually manifest lists with images for multiple
architectures, not just AMD64. This is helpful for modern clouds and
hybrid clusters, where it's possible that not all machines are AMD64.
I think this should work out of the box, since the
s3_exporterbinariesare built in the container itself, and the
golangimages are all multiarch.Signed-off-by: Lucas Servén Marín lserven@gmail.com