Skip to content

fix: add support for folder note/index pages#105

Merged
tylerdave merged 3 commits intomainfrom
folder-notes
Apr 12, 2026
Merged

fix: add support for folder note/index pages#105
tylerdave merged 3 commits intomainfrom
folder-notes

Conversation

@tylerdave
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2026

Docs Site preview: https://dea8560b.rockgarden.pages.dev

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The previously flagged logging issue has been addressed — loader.py now uses logging.getLogger(__name__) with logger.warning(...) throughout, matching the pattern in render/engine.py.

The folder-note detection logic is correct: the parts[-1] == parts[-2] slug comparison reliably identifies folder notes across all url_style values, custom slugs bypass the rewrite, and index.md files are not affected. The conflict resolution in load_content correctly demotes folder notes when an explicit index.md exists. The _index_page fallback in store.py is properly gated so stem-based matches always take precedence over the folder-name fallback. Test coverage is solid across all key cases.

@tylerdave tylerdave merged commit 32efb47 into main Apr 12, 2026
6 checks passed
@tylerdave tylerdave deleted the folder-notes branch April 12, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant