Skip to content

fix: add support for unlisted pages#106

Merged
tylerdave merged 3 commits intomainfrom
unlisted-pages
Apr 13, 2026
Merged

fix: add support for unlisted pages#106
tylerdave merged 3 commits intomainfrom
unlisted-pages

Conversation

@tylerdave
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 12, 2026

Docs Site preview: https://79c8bb37.rockgarden.pages.dev

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both previously flagged bugs are fixed and the implementation is correct.

Previously flagged issue 1 (folder_index.py — subfolder unlisted check): Resolved. Lines 237–241 now check subfolder_index.frontmatter.get("unlisted") before adding a subfolder as a folder child, mirroring the _should_hide guard that was already there.

Previously flagged issue 2 (tree.py — child pages leaking to parent level on unlisted folder break): Resolved cleanly with a for-else construct. The else block only runs when the folder-traversal loop completes without a break, so child pages of an unlisted ancestor are never inserted into current (which would have been the parent scope). The updated test now also asserts "Details" not in labels, covering the exact case that was missing before.

@tylerdave tylerdave merged commit 8945da5 into main Apr 13, 2026
6 checks passed
@tylerdave tylerdave deleted the unlisted-pages branch April 13, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant