Skip to content

fix: add custom 404 support to dev server#94

Merged
tylerdave merged 2 commits intomainfrom
dev-server-404s
Apr 5, 2026
Merged

fix: add custom 404 support to dev server#94
tylerdave merged 2 commits intomainfrom
dev-server-404s

Conversation

@tylerdave
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

Docs Site preview: https://9776c642.rockgarden.pages.dev

claude[bot]

This comment was marked as outdated.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Both previously flagged issues are resolved:

  • Hardcoded ports replaced with port=0 (OS-assigned)
  • Tests now import and exercise the real _make_handler from production code rather than reimplementing it

No new issues found.

@tylerdave tylerdave merged commit eec739b into main Apr 5, 2026
6 checks passed
@tylerdave tylerdave deleted the dev-server-404s branch April 5, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant