Add ignore_definition_args param to MaxLineLength check#1253
Open
Nezteb wants to merge 1 commit intorrrene:masterfrom
Open
Add ignore_definition_args param to MaxLineLength check#1253Nezteb wants to merge 1 commit intorrrene:masterfrom
ignore_definition_args param to MaxLineLength check#1253Nezteb wants to merge 1 commit intorrrene:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even with
ignore_definitionsbeing set totrue, there are some cases where the Elixir formatter won't split a long line if it's one of the arguments of a function definition. This will cause theMaxLineLengthCredo check to fail when it maybe shouldn't. To address this, I figured a new default-false flag would be an easier addition. 🙏