Skip to content

feat(diag): Add the 'cargo::default' group#17033

Merged
weihanglo merged 5 commits into
rust-lang:masterfrom
epage:lint-default
May 27, 2026
Merged

feat(diag): Add the 'cargo::default' group#17033
weihanglo merged 5 commits into
rust-lang:masterfrom
epage:lint-default

Conversation

@epage
Copy link
Copy Markdown
Contributor

@epage epage commented May 25, 2026

What does this PR try to resolve?

Adds a "visible by default" lint group to mirror clippy::all which should gain a clippy::default alias.

Personally, my motivation is to reduce noise in tests by making it easy to disable all lints except those under tests.

How to test and review this PR?

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 25, 2026

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, weihanglo

Copy link
Copy Markdown
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@weihanglo or @Muscraft do you have any comments before merging?

View changes since this review

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 27, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Copy Markdown
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well.

3d9c7cf cleanup is nice

View changes since this review

@weihanglo weihanglo enabled auto-merge May 27, 2026 18:38
@weihanglo weihanglo added this pull request to the merge queue May 27, 2026
Merged via the queue into rust-lang:master with commit 91c86c0 May 27, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-documenting-cargo-itself Area: Cargo's documentation A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants