feat: Add edition for scripts anytime we mutate the manifest#17038
Open
epage wants to merge 5 commits into
Open
feat: Add edition for scripts anytime we mutate the manifest#17038epage wants to merge 5 commits into
epage wants to merge 5 commits into
Conversation
Collaborator
|
r? @ehuss rustbot has assigned @ehuss. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is an experiment in finding a middle ground between two opposite perspectives
cargo fixresolves the no-edition warning by setting itcargoautomatically injects the edition whenever running a cargo scriptThis is instead "if we're already doing edits, we might as well inject the edition". This is still limited because (1) people or IDEs can do direct edits and (2)
cargo add -M script.rs serdeis a big more cumbersome thancargo add serde.We could possibly take this a step further to "all mutations" and include
cargo updateandcargo generate-lockfile.This does not include a "pinning" status message at this time.
How to test and review this PR?